Bugfix in Jruby that cause xpath with 'xmlns:' to return empty results #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 22, 2012 01:57
…ays empty array. test provided - with this testcase
yokolet
added a commit
that referenced
this pull request
Jun 14, 2012
… xpath with namespace raises an error.
|
Hello, Thanks for the patch. I've edited test/xml/test_xpath.rb before merging this pull request, so I couldn't make it automatically. Sorry. I manually merged the fix and test in rev. 11eb502 . This fix will be in since 1.5.5.rc2 and later version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this commit will fix different behaviour in MRI and JRuby when dealing with namespaces.
In current Nokogiri version xpath starting with 'xmlns:' on JRuby will result in empty node and on MRI it will provide normal results.
This commit fix this.