Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authentication drivers & Naming convention of pivot tables #30

Closed
hiendv opened this issue Dec 28, 2015 · 5 comments
Closed

Authentication drivers & Naming convention of pivot tables #30

hiendv opened this issue Dec 28, 2015 · 5 comments

Comments

@hiendv
Copy link

hiendv commented Dec 28, 2015

Since Laravel 5.2 has already supported Mupltiple Authentication, configurations like User Permissions Table (user_has_permissions) and User Roles Table (user_has_roles) should be attached to drives (array? maybe). Creating a branch for Laravel 5.2.* and higher is a great idea, I think.

Moreover, I think we should keep the naming convention of pivot tables of default configurations between these entities:
User - Permission table : permission_user
User - Role table: role_user
Permission - Role table: permission_role

@djallits
Copy link

I believe you can rename the pivot tables via the provided config file.

@hiendv
Copy link
Author

hiendv commented Dec 29, 2015

@djallits It's not that simple I'm afraid. For example, you have 2 drivers: frontend and backend. Configuring twice, publishing twice and being forced to edit the later configuration is painful ! Imagine n drivers?
@freekmurze Ping ! Let me hear your thought !

@freekmurze
Copy link
Member

We're planning on changing our Laravel template so it'll use backend users en frontend users. When that happens I'll take a look at adding support for multi auth to this package.

ETA a few months. If you need support for multi auth quick, I'll be happy to pull a PR that adds this to package.

@hiendv
Copy link
Author

hiendv commented Dec 29, 2015

So can I create a branch for Laravel 5.2.* and you will merge it later?

@freekmurze
Copy link
Member

If your changes are good, I'll merge and tag them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants