Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config file for setting table names #5

Closed
michaeljhopkins opened this issue Sep 19, 2015 · 5 comments
Closed

Config file for setting table names #5

michaeljhopkins opened this issue Sep 19, 2015 · 5 comments

Comments

@michaeljhopkins
Copy link

I think it's likely pretty common that a lot of us already have tables (from some other 3rd party acl) to do most of what this migrates. In interest of keeping db changes to a minimum, it'd be ideal for something like this

'tables' => [
    'permissions' => env('PERMISSIONS_TABLE','permissions'),
    'user_has_permissions' => env('USER_HAS_PERMISSIONS_TABLE','user_has_permissions'),
]

and so on with the rest of the tables.

Short issue, I have every table you're creating already, just named differently

@freekmurze
Copy link
Member

I'll add a config file to the package to allow naming of the tables in the near future.

@michaeljhopkins
Copy link
Author

Working on a PR just to get the functionality there. However you'll likely need to touch it up a bit

@michaeljhopkins
Copy link
Author

see if that change works for you!

cheers
-m

@freekmurze
Copy link
Member

I've added some comments to your PR.

@freekmurze
Copy link
Member

Solved in v1.2.0 of the package

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants