How do you combine Laravel Query Builder package with action class?

[rizaldywirawan]

Hi folks,

I have a question, do you use this package with action class (it could be a plain old php class or using Laravel Action by Loris Leiva)?

I mean, somehow, once I use this package to action class, the filter or the sort no longer feels natural because everything should be included in the Request or request().

What do you think? Please share your thoughts so I can get more insight.

Thank you!

[rizaldywirawan]

Below is an example of trying to filter a Product model using ids.

public function index(Request $request, Product $product, GetProducts $getProducts)
{
    $productAddonIds = ProductAddon::where('product_id', $product->id)->get()->pluck('addon_product_id');

    $request->merge([
        'filter' => [
            'id' => implode(',', $productAddonIds->toArray())
        ]
    ]);


    return new ProductCollection($getProducts->handle($request->all()));
}

Here is the action class (I use Loris Leiva action class, because it's already include the form request/validation feature):

public function handle(array $attributes = [])
{
    $this->fill($attributes);

    // validate attributes
    $validatedData = $this->validateAttributes();

    // Add filter to the request query string.
    request()->merge($validatedData);

    return QueryBuilder::for(Product::class)
        ->allowedIncludes(['variants', 'addons'])
        ->allowedFilters([
            AllowedFilter::exact('id'),
            'name',
            AllowedFilter::callback('is-bookable', function (Builder $query, $value) {

                if ($value == 'true' || $value === true) {
                    $query->whereHas('booking');
                }

            }),
            AllowedFilter::callback('addon', function (Builder $query, $value) {
                return $query->whereHas('addons', function(Builder $subQuery) use($value) {
                    $subQuery->where('product_id', $value);
                });
            })
        ])->get();
}

[rizaldywirawan]

One of the contributors suggest me to use https://github.com/illuminatech/data-provider (also he is the creator of this package). In my opinion, this one is more suitable for action class, since it does not too coupled with Request class.

But would like to know other opinions.

[rizaldywirawan]

Here is the code for now:

class ProductDataProvider extends DedicatedDataProvider
{
    public function __construct(Builder|Product $product)
    {
        parent::__construct($product);
    }


    protected function defineFilters(): array
    {
        return [
            'id',
            'product-name' => new FilterLike('name'),
            'is-bookable' => function (Builder $query, $name, $value) {
                if ($value === 'true' || $value === true) {
                    $query->whereHas('booking');
                }
            },
            'has-addons' => function(Builder $query) {
                $query->whereHas('addons');
            }
        ];
    }
}

public function handle(array $attributes = []): array|Collection
{
    $this->fill($attributes);

    // validate attributes
    $validatedData = $this->validateAttributes();

    return ProductDataProvider::new(Product::query())->get($validatedData);
}