Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the semantics of our XML schema #495

Closed
wking opened this issue Nov 26, 2017 · 8 comments
Closed

Document the semantics of our XML schema #495

wking opened this issue Nov 26, 2017 · 8 comments
Milestone

Comments

@wking
Copy link
Contributor

wking commented Nov 26, 2017

Spun off from #391, which has some links to current external-to-this-repo docs. I think we want to bring those docs into this repo so we only have one location to handle as we iterate on the schema. One thing that could use more detailed docs are the semantics of <alt> attributes, like the regexp dialect used by match and whether or not name needs to be unique within a license.

@goneall
Copy link
Member

goneall commented Nov 26, 2017

Agree as long as we don't duplicate information in the License Matching Guidelines Appendix.

I would prefer to cross-reference information in the spec so we do not have to maintain the information in 2 places.

@wking
Copy link
Contributor Author

wking commented Nov 27, 2017 via email

@goneall
Copy link
Member

goneall commented Nov 27, 2017

But why does the spec care about the format?

Format - I though we were talking about semantics ;) Agree the XML format should be in the repo. The semantics for <optional> and <alt> are the same as the <<beginOptional>> <<endOptional>> and <<var ...>> in the templates. Those semantics should be retained in the spec since they are broadly used outside the SPDX internal maintenance of the license list. The documentation in the repo can make reference to this specific section of the spec.

@wking
Copy link
Contributor Author

wking commented Nov 27, 2017 via email

@goneall
Copy link
Member

goneall commented Nov 28, 2017

Can you link a few examples? Are you thinking about external license lists?

Just the license matching guidelines appendix (see link above). Note that it defines the regexp specifics which should be the same as the <alt> regexp description.

@wking
Copy link
Contributor Author

wking commented Nov 28, 2017 via email

@goneall
Copy link
Member

goneall commented Nov 28, 2017

@wking I agree we need to straighten out the documentation but I disagree on removing the license template documentation from the spec. Currently, we have agreed that the XML format for licenses is used internally by the legal team. License templates are used externally. I don't think we want to move information needed by the external community to utilize license templates to a repository that is intended to be used internally by the legal team.

@wking
Copy link
Contributor Author

wking commented Nov 28, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants