Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the defined URI for the created by organization for references #166

Closed
goneall opened this issue Dec 7, 2024 · 2 comments · Fixed by #171
Closed

Use the defined URI for the created by organization for references #166

goneall opened this issue Dec 7, 2024 · 2 comments · Fixed by #171

Comments

@goneall
Copy link
Member

goneall commented Dec 7, 2024

The reference to ns1:createdBy <https://spdx.org/> ; as the value of createdBy is failing validation in PyShacl.

Even though the OWL file declares this to be the sameAs ns1:SpdxOrganization, it is not finding the definition.

This may be due to no reasoner being implemented in the PyShacl.

Change the references from ns1:createdBy <https://spdx.org/> ; to ns1:createdBy ns1:SpdxOrganization passes validatin.

Reference comment spdx/spdx-3-model#936 (comment)

@zvr
Copy link
Member

zvr commented Dec 9, 2024

OK, this does not make sense.
I'm thinking that this is a limitation of PyShacl.

We can do the change to circumvent it, but let's try another SHACL tester before to see where the issue is.

@goneall
Copy link
Member Author

goneall commented Dec 9, 2024

OK, this does not make sense. I'm thinking that this is a limitation of PyShacl.

We can do the change to circumvent it, but let's try another SHACL tester before to see where the issue is.

This matches a pattern I've seen in RDF tooling where anything that would involve indirect reasoning requires additional plugins or just doesn't work. Even if this is a limitation of PyShacl, we should probably keep the change since PyShacl has a substantial user base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants