You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm not sure the logic behind not using ProblemException for these. I wonder if it has something to do with making it more secure or to get better handling in Flask.
Ultimately it feels out of place when you consider adding aiohttp (and other frameworks #828#440) support.
This is related to #955, and could be included in it, but seems slightly orthogonal to that effort.
Expected behaviour
Don't extend a framework specific exception inside Zalando core.
Actual behaviour
Aiohttp ends up using the werkzeug exceptions.
Steps to reproduce
Read the code.
The text was updated successfully, but these errors were encountered:
Description
I wonder if these should extend
ProblemException
instead of the werkzeug exceptions.connexion.exceptions.OAuthProblem(werkzeug.exceptions.Unauthorized)
connexion.exceptions.OAuthResponseProblem(OAuthProblem)
connexion.exceptions.OAuthScopeProblem(werkzeug.exceptions.Forbidden)
I'm not sure the logic behind not using
ProblemException
for these. I wonder if it has something to do with making it more secure or to get better handling in Flask.Ultimately it feels out of place when you consider adding aiohttp (and other frameworks #828 #440) support.
This is related to #955, and could be included in it, but seems slightly orthogonal to that effort.
Expected behaviour
Don't extend a framework specific exception inside Zalando core.
Actual behaviour
Aiohttp ends up using the werkzeug exceptions.
Steps to reproduce
Read the code.
The text was updated successfully, but these errors were encountered: