Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow async as argument name #1507

Closed
foolip opened this issue Aug 19, 2019 · 1 comment
Closed

Allow async as argument name #1507

foolip opened this issue Aug 19, 2019 · 1 comment

Comments

@foolip
Copy link
Collaborator

foolip commented Aug 19, 2019

450e049 added async to SymbolIdents in tokenizer.py, causing it to be treated as a symbol rather than an identifier.

This caused a problem in whatwg/xhr#251:

FATAL ERROR: IDL SYNTAX ERROR LINE: 42 - skipped: "void open(ByteString method, USVString url, boolean async, optional USVString? username = null, optional USVString? password = null)"

whatwg/webidl#769 fixed this in the spec, this issue should probably be resolved by matching that, but I've framed it around the regression only as that's blocking whatwg/xhr#252.
This was referenced Aug 19, 2019
Closed
Closed
@foolip
Copy link
Collaborator Author

foolip commented Aug 19, 2019

Dupe of plinss/widlparser#42.

@foolip foolip closed this as completed Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow async as argument name
1 participant
@foolip