Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propdef grammars should link each component value to its definition #453

Open
fantasai opened this issue Aug 5, 2015 · 12 comments
Open

Comments

@fantasai
Copy link
Contributor

fantasai commented Aug 5, 2015

Compare this version, in which each keyword or function in the propdef links to its property-specific definition
http://dev.w3.org/csswg/css-fonts/#font-variant-prop
to this one, in which only <valtypes> get linked to their definition
http://dev.w3.org/csswg/css-fonts/Overview.html#font-variant-prop

@fantasai
Copy link
Contributor Author

fantasai commented Aug 5, 2015

(This might require additional markup support from the author.)

@tabatkins
Copy link
Collaborator

There's nothing to do here on the Bikeshed side; it already has all the capabilities necessary. I just marked it up differently than the original spec did.

@fantasai
Copy link
Contributor Author

fantasai commented Mar 2, 2016

No, this is not fixed. E.g. the 'ordinal' keyword in the propdef does not link to its definition, as it does in the non-Bikeshedded version.

@tabatkins
Copy link
Collaborator

Again:

There's nothing to do here on the Bikeshed side; it already has all the capabilities necessary. I just marked it up differently than the original spec did.

@fantasai
Copy link
Contributor Author

fantasai commented Apr 7, 2016

Can you mark it up in the way the Fonts editor wants it to be marked up then?

@tabatkins
Copy link
Collaborator

We don't do that for any other spec.

@fantasai
Copy link
Contributor Author

fantasai commented Apr 7, 2016

I'm not sure what's the problem here. jdaggett's linking scheme (each keyword in the propdef to its definition) is very clearly more useful. This is especially true for the Fonts spec, but I don't see why it wouldn't be more useful anywhere else. It seems to me that at least in most cases, we have enough information to do this linking. No?

@tabatkins
Copy link
Collaborator

Possibly. Sometimes the important grammar term is a longer expression than a single keyword, but yeah, single keywords could probably link up automatically.

@fantasai
Copy link
Contributor Author

fantasai commented Apr 7, 2016

Right. I think what's needed here for parity is single keywords linking up as well as function names linking up. Is that fair?

@tabatkins
Copy link
Collaborator

I should be able to do that. Open up a new issue for it?

@fantasai
Copy link
Contributor Author

fantasai commented Apr 7, 2016

Um. That's exactly what this issue is about. Why not just reopen it?

@tabatkins
Copy link
Collaborator

Indeed it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants