Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ALL Table Aggregation separators with a space at the end or beginning are ERASED after any changes to DataObjFormatters #5154

Closed
alesan99 opened this issue Jul 29, 2024 · 2 comments · Fixed by #5240 · May be fixed by #6115
Closed

ALL Table Aggregation separators with a space at the end or beginning are ERASED after any changes to DataObjFormatters #5154

alesan99 opened this issue Jul 29, 2024 · 2 comments · Fixed by #5240 · May be fixed by #6115
Assignees
@alesan99
Labels
1 - Bug Incorrect behavior of the product 2 - App Resources Issues that are related to app resources
Milestone
7.9.7

Comments

@alesan99
Copy link
Contributor

alesan99 commented Jul 29, 2024 •
edited by grantfitzsimmons
Loading

Describe the bug
If you make any changes to the Record Formatters file and save, all table aggregators with a separator set to "; " (A semicolon with a space after) will have the separator erased.
Apparently this has been happening for a while and multiple databases have been affected already.

The same separator works in table format however.

To Reproduce
Steps to reproduce the behavior:

  1. Go to App Resources -> Record Formatters -> Table Aggregation
  2. Edit Accession Agent Table Aggregation
  3. Set the Separator to "; "
  4. Close
  5. Click Save
  6. Go back to Accession Agent Table Aggregation
  7. Check the Separator

Expected behavior
This separators should be supported as it is in Table Formats.

  • OS: Windows 11
  • Browser: Chrome
  • Specify 7 Version: edge (7.9.7), 7.9.6, 7.9.5, 7.9.4
  • Database Name: kubirds & sp7demofish
  • User Name: spbirdadmin
@alesan99 alesan99 added 1 - Bug Incorrect behavior of the product 2 - App Resources Issues that are related to app resources labels Jul 29, 2024
@alesan99 alesan99 changed the title Table Aggregation separator "; " is erased after save. ALL Table Aggregation separators with "; " are ERASED after any changes to Formatters Jul 30, 2024
@grantfitzsimmons
Copy link
Member

The severity of this issue is high, and a resolution should be issued urgently.

Consider this– we are losing the aggregation separator for most tables immediately upon saving any edits to the DataObjFormatters file. Upon examining Andy's database, this issue has already become a problem in the wild.

aggregation.mp4

We need to resolve ASAP.

@grantfitzsimmons grantfitzsimmons changed the title ALL Table Aggregation separators with "; " are ERASED after any changes to Formatters ALL Table Aggregation separators with a space at the end or beginning are ERASED after any changes to Formatters Jul 30, 2024
@grantfitzsimmons grantfitzsimmons changed the title ALL Table Aggregation separators with a space at the end or beginning are ERASED after any changes to Formatters ALL Table Aggregation separators with a space at the end or beginning are ERASED after any changes to DataObjFormatters Jul 30, 2024
@grantfitzsimmons grantfitzsimmons added this to the 7.9.7 milestone Jul 30, 2024
@realVinayak
Copy link
Contributor

It assumes '; ' is the default one.

From logical perspective, the backend should also do the same:

specify7/specifyweb/stored_queries/format.py

Line 266 in 526a059

separator = aggregatorNode.attrib.get('separator', ',')

@alesan99 alesan99 mentioned this issue Aug 21, 2024
Merged
4 tasks
@alesan99 alesan99 linked a pull request Aug 21, 2024 that will close this issue
Fix Table Aggregation Separator being set to undefined if it matches default "; " #5240
Merged
4 tasks
@grantfitzsimmons grantfitzsimmons mentioned this issue Jan 17, 2025
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alesan99 alesan99

Labels
1 - Bug Incorrect behavior of the product 2 - App Resources Issues that are related to app resources
Projects
None yet
Milestone
7.9.7
3 participants
@alesan99 @grantfitzsimmons @realVinayak