Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CachingMode.GROUP to CachingMode.EACH_GROUP #668

Closed
raniejade opened this issue Apr 9, 2019 · 0 comments · Fixed by #673
Closed

Rename CachingMode.GROUP to CachingMode.EACH_GROUP #668

raniejade opened this issue Apr 9, 2019 · 0 comments · Fixed by #673
Labels
is: improvement
Milestone
2.0.3

Comments

@raniejade
Copy link
Member

by rename, I mean deprecating CachingMode.GROUP and add in CachingMode.EACH_GROUP. CachingMode.GROUP means that the value is unique per group, but the name is not apparent as it could also be interpreted as unique in the group it was declared (which is what CachingMode.SCOPE is).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
is: improvement
Projects
None yet
Milestone
2.0.3
Development

Successfully merging a pull request may close this issue.

Add CachingMode.EACH_GROUP and deprecate CachingMode.GROUP spekframework/spek
1 participant
@raniejade