Emit non-zero exit code upon non-runnable subcommand #922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
* i.e. * go get golang.org/x/lint/golint * go list ./... | xargs golint
* i.e. * go get golang.org/x/tools/cmd/goimports * goimports -w *.go * goimports -w cobra/
Closed
n10v
requested changes
Aug 1, 2019
umarcor
added a commit
to umarcor/cobra
that referenced
this pull request
Sep 5, 2019
marckhouzam
added a commit
to VilledeMontreal/acceptance-testing
that referenced
this pull request
Dec 8, 2019
There is a change in Cobra which causes the help message to be printed to stderr instead of stdout. See spf13/cobra#922 In preparation for a future upgrade to a new version of Cobra, this commit allows the tests to support both cases. Signed-off-by: Marc Khouzam <[email protected]>
jdolitsky
pushed a commit
to helm/acceptance-testing
that referenced
this pull request
Dec 9, 2019
There is a change in Cobra which causes the help message to be printed to stderr instead of stdout. See spf13/cobra#922 In preparation for a future upgrade to a new version of Cobra, this commit allows the tests to support both cases. Signed-off-by: Marc Khouzam <[email protected]>
Closed
jharshman
added a commit
to jharshman/cobra
that referenced
this pull request
Mar 26, 2020
Issue Reference: spf13#1056 when a command was not runnable. This caused all commands w/o a run function set to error w/ that message and a status code of 1. This change reverts the addition of that new error. Similar functionality can be accomplished by leveraging RunE.
Merged
jharshman
added a commit
to jharshman/cobra
that referenced
this pull request
Mar 26, 2020
Issue Reference: spf13#1056 spf13#922 introduced a new error type that emitted when a command was not runnable. This caused all commands w/o a run function set to error w/ that message and a status code of 1. This change reverts the addition of that new error. Similar functionality can be accomplished by leveraging RunE.
jharshman
added a commit
that referenced
this pull request
Mar 27, 2020
Issue Reference: #1056 #922 introduced a new error type that emitted when a command was not runnable. This caused all commands w/o a run function set to error w/ that message and a status code of 1. This change reverts the addition of that new error. Similar functionality can be accomplished by leveraging RunE.
muscliary
pushed a commit
to muscliary/cobra
that referenced
this pull request
Sep 12, 2023
Issue Reference: spf13/cobra#1056 spf13/cobra#922 introduced a new error type that emitted when a command was not runnable. This caused all commands w/o a run function set to error w/ that message and a status code of 1. This change reverts the addition of that new error. Similar functionality can be accomplished by leveraging RunE.
desdeel2d0m
added a commit
to desdeel2d0m/cobra
that referenced
this pull request
Jul 1, 2024
Issue Reference: spf13/cobra#1056 spf13/cobra#922 introduced a new error type that emitted when a command was not runnable. This caused all commands w/o a run function set to error w/ that message and a status code of 1. This change reverts the addition of that new error. Similar functionality can be accomplished by leveraging RunE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refresh of PR #642 and fixes issue #582.