Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EncodingWarning #91

Open
jaraco opened this issue Jun 19, 2024 · 4 comments
Open

EncodingWarning #91

jaraco opened this issue Jun 19, 2024 · 4 comments

Comments

@jaraco
Copy link
Contributor

jaraco commented Jun 19, 2024

I see this warning when running the docs build for setuptools:

/Users/jaraco/code/pypa/setuptools/.tox/docs/lib/python3.12/site-packages/sphinxcontrib/towncrier/ext.py:66: EncodingWarning: 'encoding' argument not specified.
  towncrier_output = subprocess.check_output(  # noqa: S603
@jaraco
Copy link
Contributor Author

jaraco commented Jul 17, 2024

Somehow, this error has turned from a warning into an error.

Correction, the warning is emitted the same as always. It was a different warning that's surfaced.

@jaraco
Copy link
Contributor Author

jaraco commented Jul 17, 2024

Still, it would be nice to see this EncodingWarning fixed so that it's not a red herring when investigating other issues.

@jaraco
Copy link
Contributor Author

jaraco commented Jul 17, 2024

I tried suppressing the errors by putting this in the docs job for tox:

env =
	# suppress sphinx-contrib/sphinxcontrib-towncrier#91
	PYTHONWARNINGS=	ignore:'encoding' argument not specified

But it did not work, possibly because of the -W parameter to Sphinx.

@webknjaz
Copy link
Member

Agreed, this should be fixed. EncodingWarning becomes an error if you involve python -bb, for example (single -b for just warning).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants