Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernising the basic theme #10646

Open
AA-Turner opened this issue Jul 6, 2022 · 4 comments
Open

Modernising the basic theme #10646

AA-Turner opened this issue Jul 6, 2022 · 4 comments
Labels
html theme type:enhancement enhance or introduce a new feature

Comments

@AA-Turner
Copy link
Member

The basic theme is showing its age -- non-responsive, and not really a great advert for Sphinx out-of-the-box.

Improving it is tricky though, as almost every theme relies on it through Jinja templating.

I see two options:

  1. Try and modernise the theme, whilst preserving compatability as much as humanly possible.
  2. Start over with basic v2

(1) is more attractive as the benefits flow through, but perhaps a lot more work.

At some point we should also evaluate the stable of default themes and if that needs a refresh, but I think the basic work is more pressing.

A

@AA-Turner AA-Turner added type:enhancement enhance or introduce a new feature html theme labels Jul 6, 2022
@AA-Turner AA-Turner added this to the 5.x milestone Jul 6, 2022
@humitos
Copy link
Contributor

humitos commented Jul 12, 2022

I know that @pradyunsg and @choldgraf have had some good discussions about a newer basic theme and they created https://github.com/pradyunsg/sphinx-basic-ng/. It may be useful to take those conversations and code as a base to decide the direction of this work in case it can be reused.

@tk0miya
Copy link
Member

tk0miya commented Jul 16, 2022

I don't have knowledge of modern HTML. So I'm not sure which option is better. But +1 for improvement if somebody will help us.

At some point we should also evaluate the stable of default themes and if that needs a refresh, but I think the basic work is more pressing.

All bundled themes are not maintained well. So it might be time to unbundle.

@pradyunsg
Copy link
Contributor

I'd be more than happy to help out with this -- see also #10419 (comment) where I responded to the suggestion of borrowing the new things from basic-ng!

@AA-Turner
Copy link
Member Author

Thank you Pradyun!

A

@AA-Turner AA-Turner modified the milestones: 5.x, 6.x Oct 4, 2022
@AA-Turner AA-Turner modified the milestones: 6.x, 7.x Apr 29, 2023
@AA-Turner AA-Turner modified the milestones: 7.x, 8.x Jul 20, 2024
@AA-Turner AA-Turner modified the milestones: 8.x, some future version Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
html theme type:enhancement enhance or introduce a new feature
Projects
None yet
Development

No branches or pull requests

4 participants