Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extension error when using metadata with parallel-read #8256

Closed
rscohn2 opened this issue Sep 30, 2020 · 2 comments
Closed

extension error when using metadata with parallel-read #8256

rscohn2 opened this issue Sep 30, 2020 · 2 comments

Comments

@rscohn2
Copy link
Contributor

rscohn2 commented Sep 30, 2020

The notfound extension gets an error when using parallel read. It is described here:
readthedocs/sphinx-notfound-page#111

Can you look it over to see if it should be safe to use metadata and parallel read together?
@jakobandersen
Copy link
Contributor

It looks to me like the OrphanMetadataCollector class does not implement all necessary methods. In particular the merge_other method is needed when running in parallel (https://github.com/sphinx-doc/sphinx/blob/3.x/sphinx/environment/collectors/__init__.py#L55).

@rscohn2
Copy link
Contributor Author

rscohn2 commented Sep 30, 2020

I will fix the problem in the extension. Thanks.

@rscohn2 rscohn2 closed this as completed Sep 30, 2020
@rscohn2 rscohn2 mentioned this issue Oct 1, 2020
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rscohn2 @jakobandersen