Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Neo,Applying new propagation method to Neo blocks,keep running!!! #547

Closed
dsfofwuc opened this issue Mar 15, 2022 · 6 comments
Closed

Comments

@dsfofwuc
Copy link

Description

We upgraded from craftcms3.4 and craft-neo2.5.10 to craftcms3.7.28 and neo2.12.5 and found some problems. After the upgrade, Queue has been running. It has been running for about 20 hours, and it is still increasing. The specific The composer configuration file is as shown below, the Queue Manager screenshot is as follows, and the queue.log file is detailed in the attachment. Please help to see what the problem is, thank you

Steps to reproduce

1.Upgrade craftcms and Neo

Other information

  • Neo version:2.12.5
  • Craft version:3.7.28
  • (if multi-site) What is the affected Neo field's propagation method:
  • Is eager-loading used?
    image
    image
    image
    image
    image
@dsfofwuc
Copy link
Author

Hope for a quick fix, thanks

@ttempleton
Copy link
Contributor

See #526 (comment) for an explanation of why this happened. As mentioned in that comment, if you've never changed the propagation method on any of your Neo fields, then it's safe to cancel the jobs.

I'll add a console command to add the jobs later this week, instead of doing it through a migration, and I'll see if I can reduce the number of jobs at the same time.

@dsfofwuc
Copy link
Author

See #526 (comment) for an explanation of why this happened. As mentioned in that comment, if you've never changed the propagation method on any of your Neo fields, then it's safe to cancel the jobs.

I'll add a console command to add the jobs later this week, instead of doing it through a migration, and I'll see if I can reduce the number of jobs at the same time.


@ttempleton
Thank you, I cancel all the jobs, I feel no error; but the craftcms page is very slow to load, save data is also very slow and save Entries 504 time out

@ttempleton
Copy link
Contributor

There were some performance issues with Neo and Matrix fields, but they should have been fixed a few months ago. Does it load and save fine if Neo is disabled?

(As a side note, Neo 2.13.0 has just been released, which moves the reapplying of Neo fields' propagation methods to a console command, php craft neo/fields/reapply-propagation-method. Reapplying using the --by-block-structure option may be required to fix the bug mentioned in #526 (comment) and may still generate a large number of jobs, but shouldn't be as many as before, as it now skips blocks that belong to an entry revision.)

@dsfofwuc
Copy link
Author

There were some performance issues with Neo and Matrix fields, but they should have been fixed a few months ago. Does it load and save fine if Neo is disabled?

(As a side note, Neo 2.13.0 has just been released, which moves the reapplying of Neo fields' propagation methods to a console command, php craft neo/fields/reapply-propagation-method. Reapplying using the --by-block-structure option may be required to fix the bug mentioned in #526 (comment) and may still generate a large number of jobs, but shouldn't be as many as before, as it now skips blocks that belong to an entry revision.)

@ttempleton After Neo is disabled, the save entry is still 504, but refreshing the page data is saved again; 504 will appear every time you save

@ttempleton
Copy link
Contributor

It doesn't seem to be caused by Neo, then, if it's still happening when Neo is disabled. I see you've also opened craftcms/cms#10759 so hopefully the suggestions there resolve your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants