Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyIdentifierValue is broken when replicas > 1 #521

Open
kfox1111 opened this issue Jan 24, 2025 · 1 comment
Open

keyIdentifierValue is broken when replicas > 1 #521

kfox1111 opened this issue Jan 24, 2025 · 1 comment

Comments

@kfox1111
Copy link
Collaborator

The current implementation of keyIdentifierValue configuration in the chart is broken. It only allows one name, breaking when replicas > 1

In statefulset mode, we should append the statefulset pod id number to it automatically to keep it unique.

We should also make sure we reject configuration when mode is deployment, replicas > 1 and keyIdentifierValue is set

@faali1
Copy link

faali1 commented Jan 24, 2025

Just to add a little bit more context, with the current keyIdentifierValue implementation, if you have replicas > 1 all the pods try to use the same key (because the identifier is the same.) This can lead to race conditions with UpdateAlias and DisposeKeys

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants