From 1edd595a1908d018dda2019cec4269a30310f504 Mon Sep 17 00:00:00 2001
From: Matt Sicker <msicker@apple.com>
Date: Wed, 15 Nov 2023 12:44:06 -0600
Subject: [PATCH] fix(core): RetrofitError thrown on login (#1737)

This fixes a regression from when PermissionService was converted from
Groovy to Java. Ideally, we'd remove the extra parameter from
FiatService directly, but that requires patching Fiat first, something
that'll be easier to do when we migrate to the monorepo.

(cherry picked from commit 5f73a67b3de899a8d519d225f657b5d81e63c44a)
---
 .../netflix/spinnaker/gate/services/PermissionService.java    | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gate-core/src/main/java/com/netflix/spinnaker/gate/services/PermissionService.java b/gate-core/src/main/java/com/netflix/spinnaker/gate/services/PermissionService.java
index 7481359b03..91c32e9f65 100644
--- a/gate-core/src/main/java/com/netflix/spinnaker/gate/services/PermissionService.java
+++ b/gate-core/src/main/java/com/netflix/spinnaker/gate/services/PermissionService.java
@@ -77,7 +77,9 @@ public void login(final String userId) {
       try {
         AuthenticatedRequest.allowAnonymous(
             () -> {
-              getFiatServiceForLogin().loginUser(userId, null);
+              // TODO(jvz): FiatService::loginUser should have only one parameter as Retrofit no
+              // longer requires this body parameter
+              getFiatServiceForLogin().loginUser(userId, "");
               permissionEvaluator.invalidatePermission(userId);
               return null;
             });