-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stripe Strong Customer Authentication #330
Comments
I've just been investigating this myself. It looks as though spree_gateway doesn't currently support this. It supports v3 of the Stripe api, but still uses the old methods for creating a token and active merchant to process the payment. This doesn't work for supporting 3D secure which appears to by default require using Stripe payment intents functions. I could be wrong, this is how I interpreted it. There is a pull request for active merchant which seems to support the new Stripe payment intents api (activemerchant/active_merchant#3290). Once this is merged into active merchant, this gem will need updating to use the new functionality. I'm hoping this will enable support for SCA and 3D Secure, I guess by redirecting the user to the 3D secure confirmation page? It would be really helpful to have an update from someone who knows more about the spree_gateway gem, because the deadline is just over a month away. I'm happy to help writing a pull request. |
Few days ago Active Merchant added the new gateway Stripe Payment Intents to support SCA and 3D Secure. Is anyone working on updating this gem to be able to use this gateway?? |
Any news about Stripe Payment Intents API implementation? |
@damianlegawiec @dyerc @manikkang - Any update on this? |
@AnkurVyas-BTC you can track progress here: #355 |
@damianlegawiec - Cool 👍 |
Any word on this being updated? I just got an email from Stripe warning that payments are going to be declined |
Any updates about when this PR #355 will be merged? |
Are we there yet? #355 seems complete or am I wrong? |
I'm interested in an update as well |
Hello @damianlegawiec In pull request mentioned above #355 we only give support for processing payments using Stripe's PaymentIntent in Spree UI. Are we going to add support for Spree Storefront API V2 too? I'm working on a project which requires SCA supported payments. I'm no expert here, but it'll be great if you can lead me in the right direction. Currently, I tried to use the code of #355 PR, and I can easily process normal payments by using Stripe's createToken method. But it seems that the method doesn't support SCA. So now, I'm wondering how to make it work with Stripe's PaymentMethod creation method. I'm using https://github.com/spree/spree-storefront-api-v2-js-sdk and stripe/react-stripe-js v1.1.2 and stripe/stripe-js v1.5.0 Here's the code snippet. if (!result.error) { And in the backend, I get below error message. Spree::Core::GatewayError at /api/v2/storefront/checkout
Thanks. |
I believe #355 handles all Spree UI stuff. I need to make it work for API V2, so it'll be great if you can lead me in the right direction. @damianlegawiec |
I found the solution. Thanks for implementing Stripe SCA. |
@satyakam-nividata could you share that solution? Yes, our plan is to have this also in the headless API mode as well |
Here's how I managed to make it work in API mode.
I used result.token.id in the below code. ` const { token } = nextCookie({}); const payment = await client.checkout.paymentMethods({ if (payment.isSuccess()) {
` I added 2 methods in CheckoutControllerDecorator `module MyProject
end Spree::Api::V2::Storefront::CheckoutController.prepend MyProject::CheckoutControllerDecorator In routes.rb
I think it's good to go. Any suggestions are much appreciated. |
Hello @damianlegawiec, Any suggestions for the above solution? |
Stripe Api uses new methods for creating the charge. Has the gem being updated to accordingly?
The text was updated successfully, but these errors were encountered: