Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actuator content negotiation handles a single Accept header with multiple values incorrectly #28137

Closed
wilkinsona opened this issue Sep 27, 2021 · 1 comment
Closed

Actuator content negotiation handles a single Accept header with multiple values incorrectly #28137

wilkinsona opened this issue Sep 27, 2021 · 1 comment
Assignees
@wilkinsona
Labels
status: invalid An issue that we don't feel is valid type: bug A general bug

Comments

@wilkinsona
Copy link
Member

When the underlying web framework returns a single value for the Accept header that contains a comma-separated list of values, the single-item list is made available to ProducibleOperationArgumentResolver. It does not handle it correctly as it treats the entire string as a single value rather than multiple comma-separated values.
@wilkinsona wilkinsona added the type: bug A general bug label Sep 27, 2021
@wilkinsona wilkinsona added this to the 2.4.x milestone Sep 27, 2021
@wilkinsona wilkinsona self-assigned this Sep 27, 2021
@wilkinsona wilkinsona mentioned this issue Sep 27, 2021
Closed
@wilkinsona
Copy link
Member Author

Nope. MimeTypeUtils.tokenize(accept) takes care of this and the behaviour's covered by ProducibleOperationArgumentResolverTests.whenMultipleValuesAreAcceptableAsSingleHeaderThenHighestOrdinalIsReturned()

@wilkinsona wilkinsona removed this from the 2.4.x milestone Sep 27, 2021
@wilkinsona wilkinsona added the status: invalid An issue that we don't feel is valid label Sep 27, 2021
@ThomasKasene ThomasKasene mentioned this issue Oct 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wilkinsona wilkinsona

Labels
status: invalid An issue that we don't feel is valid type: bug A general bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wilkinsona