Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Brave BOM to v6 & support Zipkin reporter v3 #39116

Closed
mmoayyed opened this issue Jan 12, 2024 · 1 comment
Closed

Upgrade Brave BOM to v6 & support Zipkin reporter v3 #39116

mmoayyed opened this issue Jan 12, 2024 · 1 comment
Labels
status: duplicate A duplicate of another issue

Comments

@mmoayyed
Copy link
Contributor

Environment

Spring Boot 3.2.1
Java 21

Request

This is an enhancement request to allow Spring Boot to support brave-bom 6.x, and in turn have it support the zipkin-reporter-brave 3.x. Boot seems to be at:

     library("Brave", "5.17.0") {
		group("io.zipkin.brave") {
			imports = [
				"brave-bom"
			]
		}
	}

Presently, using 3.x causes the following:

Caused by: java.lang.NoClassDefFoundError: zipkin2/codec/BytesEncoder
	at java.base/java.lang.Class.getDeclaredMethods0(Native Method)
	at java.base/java.lang.Class.privateGetDeclaredMethods(Class.java:3578)
	at java.base/java.lang.Class.getDeclaredMethods(Class.java:2676)
	at org.springframework.util.ReflectionUtils.getDeclaredMethods(ReflectionUtils.java:465)
	... 37 more
Caused by: java.lang.ClassNotFoundException: zipkin2.codec.BytesEncoder
	at java.base/java.net.URLClassLoader.findClass(URLClassLoader.java:445)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:593)
	at org.springframework.boot.loader.net.protocol.jar.JarUrlClassLoader.loadClass(JarUrlClassLoader.java:104)
	at org.springframework.boot.loader.launch.LaunchedClassLoader.loadClass(LaunchedClassLoader.java:91)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:526)
	... 41 more

The main culprit is here.

The template here did suggest that, "BUT pull requests for upgrades that are more involved than just a version property change are still most welcome." and I think this does qualify given compatibility issues and it being a non-trivial dependency upgrade. I suspect this change, if accepted, would be more appropriate for Spring Boot 3.3.x.

If you'd like to see a pull request, please let me know.

Thank you!

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 12, 2024
@wilkinsona
Copy link
Member

Duplicates #39049.

@wilkinsona wilkinsona closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2024
@wilkinsona wilkinsona added status: duplicate A duplicate of another issue and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate A duplicate of another issue
Projects
None yet
Development

No branches or pull requests

3 participants