Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in TestcontainersPropertySource #39438

Closed
sbrannen opened this issue Feb 7, 2024 · 3 comments
Closed

Fix typo in TestcontainersPropertySource #39438

sbrannen opened this issue Feb 7, 2024 · 3 comments
Assignees
@amritagg
Labels
status: superseded An issue that has been superseded by another

Comments

@sbrannen
Copy link
Member

sbrannen commented Feb 7, 2024

spring-boot/spring-boot-project/spring-boot-testcontainers/src/main/java/org/springframework/boot/testcontainers/properties/TestcontainersPropertySource.java

Line 132 in b1bf4bb

"Incorrect DynamicValuesPropertySource type registered");

That should read "Incorrect TestcontainersPropertySource type registered".
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Feb 7, 2024
@mhalbritter mhalbritter added status: ideal-for-contribution An issue that a contributor can help us with type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Feb 7, 2024
@mhalbritter mhalbritter added this to the 3.1.x milestone Feb 7, 2024
@amritagg
Copy link
Contributor

amritagg commented Feb 7, 2024

Hello @sbrannen Can you assign me this issue?

@amritagg
Copy link
Contributor

amritagg commented Feb 7, 2024

Attaching the PR here: #39440

@scottfrederick
Copy link
Contributor

Closing in favor of #39440

@scottfrederick scottfrederick closed this as not planned Won't fix, can't repro, duplicate, stale Feb 7, 2024
@scottfrederick scottfrederick added status: superseded An issue that has been superseded by another and removed type: bug A general bug status: ideal-for-contribution An issue that a contributor can help us with labels Feb 7, 2024
@scottfrederick scottfrederick removed this from the 3.1.x milestone Feb 7, 2024
@philwebb philwebb changed the title Fix typo in TestcontainersPropertySource Fix typo in TestcontainersPropertySource Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amritagg amritagg

Labels
status: superseded An issue that has been superseded by another
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@scottfrederick @sbrannen @spring-projects-issues @amritagg @mhalbritter