Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make FilterRegistrationBean generic #7666

Closed
bclozel opened this issue Dec 16, 2016 · 1 comment
Closed

Make FilterRegistrationBean generic #7666

bclozel opened this issue Dec 16, 2016 · 1 comment
Assignees
Labels
type: enhancement A general enhancement
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Dec 16, 2016

While trying to fix #7475, it appears that early instantiation is currently the only way to get the type information about the Servlet filter that is about to be created by a FilterRegistrationBean. Doing so in a Condition can cause many initialization issues.

FilterRegistrationBean needs to be made generic, so as to look like FilterRegistrationBean<MyServletFilter>. This will make it easier to the type information without instantiating the bean and will make the registration more expressive about its intent.

@bclozel bclozel added the type: enhancement A general enhancement label Dec 16, 2016
@bclozel bclozel added this to the 2.0.0.M1 milestone Dec 16, 2016
@bclozel bclozel self-assigned this Dec 16, 2016
@philwebb
Copy link
Member

Whilst we're at it we should look at the others as well (ServletRegistrationBean for example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

3 participants