Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embeddeds are not working with Jackson REQUIRE_SETTERS_FOR_GETTERS configuration [DATAREST-742] #1115

Closed
spring-projects-issues opened this issue Jan 7, 2016 · 3 comments
Assignees
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: bug A general bug

Comments

@spring-projects-issues
Copy link

Micha Reiser opened DATAREST-742 and commented

The embeddeds are not emitted for PersistedEntityResources when MapperFeature.REQUIRE_SETTERS_FOR_GETTERS is used. Add an explicit JsonProperty annotation to enforce JSON output for getEmbedded in the PersistentEntityResourceSerializer

Fixed with Jackson 2.6.4 #1013 (FasterXML/jackson-databind#1013)
So if someone can close the issue but leave it for documentation purpose...


Affects: 2.4.2 (Gosling SR2)

Reference URL: FasterXML/jackson-databind#1013

Referenced from: pull request #204

@spring-projects-issues
Copy link
Author

Oliver Drotbohm commented

I wouldn't mind applying the fix nonetheless as it doesn't seem to hurt and would allow us to get this to work on older Jackson generations (Fowler is still on 2.5). So I am still up for a test case on the PR and would happily apply it then :)

@spring-projects-issues
Copy link
Author

Micha Reiser commented

Ok I will try to implement one... Tried this morning and failed because of the newer Jackson version. It's hard to verify that the test is working...

@spring-projects-issues
Copy link
Author

Oliver Drotbohm commented

Alright. Gosling is already on 2.6.x as well. I think we can just leave it as is and recommend people to upgrade to Jackson 2.6.4 in case they run into the issue

@spring-projects-issues spring-projects-issues added type: bug A general bug status: declined A suggestion or change that we don't feel we should currently apply labels Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: declined A suggestion or change that we don't feel we should currently apply type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants