-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to HAL browser version that supports nested _embedded declarations [DATAREST-941] #1311
Comments
Oliver Drotbohm commented I've just upgraded to to the most recent version (from August 28th). Looks like we missed a couple of intermediate updates as the version numbers don't sort naturally. I just gave it a quick spin and it seems like the latest upgrade breaks our custom POST form integration. Greg Turnquist, would you mind having a look? |
Greg Turnquist commented Okay |
Greg Turnquist commented Looks like the browser.html file inside the WebJar has had considerable changes. We throw it away and have a clone copy, with our custom code to replace it. Looks like we something a little more flexible to handle this and future changes |
Oliver Drotbohm commented Do you think we can get a quick fix in for the RC? |
Greg Turnquist commented If I can figure out how to tweak things inside the maven build job, it might just work. Monday okay? |
Oliver Drotbohm commented Of course! :) |
Greg Turnquist commented I have a testable solution, but have also submitted mikekelly/hal-browser#89 to embed a more pragmatic pattern to search-and-replace with in the future |
Greg Turnquist commented Patch has been tested and submitted as pull request |
Oliver Drotbohm commented Thanks, Greg. That's merged |
Sebastian Schlick opened DATAREST-941 and commented
Please add support for multiple levels of embedded Resource Objects. See also:
mikekelly/hal-browser#73
Referenced from: pull request #243, and commits 015a8a3, aea766b, 9d57953, 9fea1ab, f4705c8
Backported to: 2.6 RC1 (Ingalls)
The text was updated successfully, but these errors were encountered: