Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation error in "SimpleJdbcInsert" section [SPR-12639] #17240

Closed
spring-projects-issues opened this issue Jan 18, 2015 · 4 comments
Closed

Documentation error in "SimpleJdbcInsert" section [SPR-12639] #17240

spring-projects-issues opened this issue Jan 18, 2015 · 4 comments
Assignees
@snicoll
Labels
status: backported An issue that has been backported to maintenance branches type: documentation A documentation task
Milestone
4.1.5

Comments

@spring-projects-issues
Copy link
Collaborator

Mithun Gooty opened SPR-12639 and commented

Section where the issue is identified:
14.5.2 Retrieving auto-generated keys using SimpleJdbcInsert

There is an explanation about the sample code to demonstrate SimpleJdbcInsert. In this section, the method name is wrongly documented. It should be changed from "executeReturningKey" to "executeAndReturnKey".

Reference URL: http://docs.spring.io/spring/docs/current/spring-framework-reference/html/jdbc.html#jdbc-simple-jdbc-insert-2

Backported to: 3.2.14
@spring-projects-issues
Copy link
Collaborator Author

Mithun Gooty commented

Could you please let me know if I Can pick up this task for fixing the documentation?

@spring-projects-issues
Copy link
Collaborator Author

Stéphane Nicoll commented

Sure, a pull request is more than welcome. Check the contributing page for more details.

@spring-projects-issues
Copy link
Collaborator Author

Mithun Gooty commented

I have made the changes in the documentation. Please find the pull request below:

#722

@spring-projects-issues
Copy link
Collaborator Author

Stéphane Nicoll commented

Merged, thanks! Also backported to 4.1.x

@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches type: documentation A documentation task labels Jan 11, 2019
@spring-projects-issues spring-projects-issues added this to the 4.1.5 milestone Jan 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snicoll snicoll

Labels
status: backported An issue that has been backported to maintenance branches type: documentation A documentation task
Projects
None yet
Milestone
4.1.5
Development

No branches or pull requests
2 participants
@snicoll @spring-projects-issues