Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle compiler error for springwolf-core 0.11.0 #232

Closed
hirth-abi opened this issue Jun 19, 2023 · 9 comments
Closed

Gradle compiler error for springwolf-core 0.11.0 #232

hirth-abi opened this issue Jun 19, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@hirth-abi
Copy link

Describe the bug

After upgrading springwolf-core to 0.11.0, Gradle logs the listed compiler error. The compilation still succeeds.

Dependencies and versions used

implementation "io.github.springwolf:springwolf-core:0.11.0"
runtimeOnly "io.github.springwolf:springwolf-ui:0.8.0"

Stack trace and error logs

Errors occurred while build effective model from .../.gradle/caches/modules-2/files-2.1/io.github.springwolf/springwolf-core/0.11.0/1329cd32162c64d095a250a0769d21f63e283355/springwolf-core-0.11.0.pom:
	  'dependencies.dependency.version' for io.swagger.core.v3:swagger-models-jakarta:jar is missing. in io.github.springwolf:springwolf-core:0.11.0
@hirth-abi hirth-abi added the bug Something isn't working label Jun 19, 2023
@sam0r040
Copy link
Collaborator

sam0r040 commented Jun 23, 2023

Hi @hirth-abi, thanks for reporting the bug. We are already working to provide a fix.

@timonback
Copy link
Member

@sam0r040 and me analyzed this yesterday. While we are not able to reproduce this exactly, we stumbled in another project over
[WARNING] The POM for io.github.springwolf:springwolf-core:jar:0.11.0 is invalid, transitive dependencies (if any) will not be available, enable debug logging for more details when building with maven.

We believe the issue is that the version attribute is not set for all dependencies.
And the underlying issue being relying on gradle dependency management (versions being managed in dependencies.gradle) which is not picked up when generated the releaseMaven artifact (including the pom file).

@timonback
Copy link
Member

Latest snapshot build contains the version field for all dependencies (except spring ones): https://s01.oss.sonatype.org/content/repositories/snapshots/io/github/springwolf/springwolf-core/0.11.0-SNAPSHOT/springwolf-core-0.11.0-20230625.220629-2.pom

@maksymgendin
Copy link

maksymgendin commented Jun 26, 2023

image

This is probably a consequential error due to the versions error in springwolf-core? io.swagger.oas.inflector.processors.JsonNodeExampleSerializer cannot be resolved on application startup when springwolf is enabled.

@timonback
Copy link
Member

Thank you for the report @maksymgendin

Are you (@maksymgendin and/or @hirth-abi) able to verify whether the current snapshot version resolves the issue?
You will need to use the -SNAPSHOT version AND add the snapshot maven repo as mentioned in the README.md: https://github.com/springwolf/springwolf-core#development
(Updated docs: https://github.com/springwolf/springwolf-core/pull/245/files )

FYI: We are preparing a patch release: #244

@hirth-abi
Copy link
Author

Yes, I have no compiler error with 0.11.0-SNAPSHOT

@sam0r040
Copy link
Collaborator

Thanks for verifying the fix. We will push forward with a patch release then.

@timonback
Copy link
Member

Thank you for the reports. The patch release is available now.

@maksymgendin
Copy link

@timonback Sorry for the late reply. Runtime works as well, thanks for the fix ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants