Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix remaining layout issues with sidebar heading font size and element margin heights #27

Merged
merged 2 commits into from
May 7, 2018
Merged

Conversation

CAM-Gerlach
Copy link
Member

Pull Request Checklist

  • Read and followed this repo's Contributing Guidelines
  • Based your PR on the latest version of the correct branch (master or 3.x)
  • Checked your writing carefully for correct English spelling, grammar, etc
  • Described your changes and the motivation for them below
  • Noted what issue(s) this pull request resolves, creating one if needed

Description of Changes

Fixes remaining layout issues mentioned in #21 — sets the sidebar headers to the size of the main content subheads, and fixes the spacing around lists (adding bottom margin) and manual linebreaks (removing excess margin). Thanks to @dalthviz for his help with much of the CSS.

Before:

image

After:

image

Issue(s) Resolved

Fixes #25

Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @CAM-Gerlach!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants