Explicitly check value of deploy vars in GHA to ensure correct logic #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAM-Gerlach
force-pushed
the
fix-gha-deploy-logic
branch
from
5f7d2a4 to
3cbaa67
Compare
|
Going ahead and merging since this fixes an urgent deploy issue and can only be fully tested directly on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Pull Request Checklist
Description of Changes
The final production deploy of #367 failed because the deploy logic was off; these checks of the GHA env vars need to explicitly check for
'1'and not just truthy as'0'is also truthy. This should fix it. Also, see if the yet another brabd new linkcheck error re-occurs.