Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorten file names to not pass 15 characters #15

Closed
ccordoba12 opened this issue Jan 8, 2017 · 2 comments
Closed

Shorten file names to not pass 15 characters #15

ccordoba12 opened this issue Jan 8, 2017 · 2 comments
Assignees
@dalthviz
Labels
type:Enhancement
Milestone
v0.1

Comments

@ccordoba12
Copy link
Member

Notebook file titles can be really long. We have to prevent showing the full file name and shorten it somehow.
@ccordoba12 ccordoba12 added this to the v0.1 milestone Jan 8, 2017
@ccordoba12 ccordoba12 changed the title Short file titles name to not pass 15 characters or so Shorten file titles name to not pass 15 characters or so Jan 9, 2017
@ccordoba12 ccordoba12 changed the title Shorten file titles name to not pass 15 characters or so Shorten file names to not pass 15 characters or so Jan 9, 2017
@ccordoba12
Copy link
Member Author

@dalthviz, please also work on this one.

@goanpeca, do you have some UI suggestions about how we should solve this problem?

@ccordoba12
Copy link
Member Author

@dalthviz, let's change the get_short_name attribute of NotebookClient for this by taking the first 15 characters of self.name and make get_short_name return that.

Also, you need to make tabs have that result as their name.

@dalthviz dalthviz mentioned this issue Jan 15, 2017
Merged
@ccordoba12 ccordoba12 changed the title Shorten file names to not pass 15 characters or so Shorten file names to not pass 15 characters Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dalthviz dalthviz

Labels
type:Enhancement
Projects
None yet
Milestone
v0.1
Development

No branches or pull requests
3 participants
@ccordoba12 @goanpeca @dalthviz