Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Fix minor issues with the tutorial as pointed out by Dr. Fangohr himself #7765

Merged
merged 1 commit into from
Aug 24, 2018

Conversation

CAM-Gerlach
Copy link
Member

Pull Request Checklist

  • Read and followed this repo's Contributing Guidelines
  • Based your PR on the latest version of the correct branch (master or 3.x)
  • Followed PEP8 for code style
  • Ensured your pull request hasn't eliminated unrelated blank lines/spaces,
    modified the spyder/defaults directory, or added new icons/assets
  • Described your changes and the motivation for them below

Description of Changes

Makes the minor fixes/tweaks suggested by Dr. @fangohr himself in review comments on #7659 and #7643 .

@ccordoba12
Copy link
Member

I'll let @fangohr review and approve this one.

@ccordoba12 ccordoba12 removed their request for review August 24, 2018 21:25
@fangohr
Copy link
Contributor

fangohr commented Aug 24, 2018

Many thanks for the work on this, and taking my suggestions for change into account. It looks very good to me.

@ccordoba12
Copy link
Member

Thanks @fangohr! Merging then.

@ccordoba12 ccordoba12 merged commit 97fc31c into spyder-ide:3.x Aug 24, 2018
ccordoba12 added a commit that referenced this pull request Aug 24, 2018
@CAM-Gerlach CAM-Gerlach deleted the tutorial-minor-fixes branch September 12, 2018 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants