Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add possibility to disable history logging #9858

Closed
wants to merge 1 commit into from

Conversation

oscargus
Copy link
Contributor

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)
  • Included a screenshot or animation (if affecting the UI, see Licecap)

Added the possibility to disable history logging.
historylogging

By design this is always enabled when starting Spyder. I thought about adding a configuration option for it and storing upon exit. However, it seems to be a potential source of issue reports... Also, I added it as a button for easy access (adding it to the corner menu may be a possibility, but then it seems like one may just as well not add it...). To make it a bit more clear I used two different icons. Maybe one can make it even more clear by, say, a red cross above it when disabled, but I'm not really a GUI designer (nor a programmer...).

There are also tool tip texts that changes from "History logging enabled" to "History logging disabled".

Not sure how to write a test for this. I could not find any tests for the history logging in the IPython console, so nothing to really copy for modification...

Issue(s) Resolved

Fixes #716

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: Oscar Gustafsson/@oscargus

@ccordoba12 ccordoba12 changed the title PR: Added possibility to disable history logging PR: Add possibility to disable history logging Jul 19, 2019
@oscargus
Copy link
Contributor Author

Just learnt about #7141. If that is merged, I belive that this PR will not be any useful (will not work) anymore. I'll wait with closing it until #7141 is merged though.

@ccordoba12
Copy link
Member

Sorry to make you waste your time, but the plan is to merge #7141 in beta5 (to be released next month).

After that, you could reimplement this using IPython config system, like we do here:

https://github.com/spyder-ide/spyder-kernels/blob/master/spyder_kernels/console/start.py#L100

But for that, we also need to merge first the improvements @impact27 has done to our kernel communication architecture, which I hope to do next week.

@ccordoba12 ccordoba12 closed this Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to toggle pausing history logging
2 participants