Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting data in the table component is broken when searching is not also enabled #660

Closed
DSMejantel opened this issue Oct 31, 2024 · 2 comments
Closed

Sorting data in the table component is broken when searching is not also enabled #660

DSMejantel opened this issue Oct 31, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@DSMejantel
Copy link

Introduction

Since 0.30, Sorting data from table component don't work on the most of my page.

To Reproduce

Il tried with Firefox ans Chrome on computer or smartphone and two différents applications.

Version information

  • OS: Ubuntu 22.04
  • Database e.g. SQLite,
  • SQLPage Version 0.30
@DSMejantel DSMejantel added the bug Something isn't working label Oct 31, 2024
@DSMejantel
Copy link
Author

Sorting data is possible only when we have 'TRUE as search' in the top level parameters. Before in sqlpage 0.29 'TRUE as sort' was only necessary.

@lovasoa
Copy link
Collaborator

lovasoa commented Oct 31, 2024

Thank you for the quick report, @DSMejantel !

I'm releasing v0.30.1 with a fix for this issue.

I also added tests to prevent other regressions in this area in the future.

@lovasoa lovasoa changed the title Sorting data in table component Sorting data in table component is broken when searching is not also enables Oct 31, 2024
@lovasoa lovasoa changed the title Sorting data in table component is broken when searching is not also enables Sorting data in table component is broken when searching is not also enabled Oct 31, 2024
@lovasoa lovasoa changed the title Sorting data in table component is broken when searching is not also enabled Sorting data in the table component is broken when searching is not also enabled Oct 31, 2024
@BrewTestBot BrewTestBot mentioned this issue Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lovasoa @DSMejantel