Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.0.0-SNAPSHOT] - Junit reports seem to not be genereated #498

Closed
jaredsburrows opened this issue Nov 16, 2017 · 11 comments
Closed

[2.0.0-SNAPSHOT] - Junit reports seem to not be genereated #498

jaredsburrows opened this issue Nov 16, 2017 · 11 comments

Comments

@jaredsburrows
Copy link
Contributor

All tests run but junit reports are not generated.

1.7.1

screen shot 2017-11-15 at 4 05 34 pm

2.0.0-SNAPSHOT

screen shot 2017-11-15 at 4 05 25 pm

@jaredsburrows
Copy link
Contributor Author

This is really bad because we do not know which tests would have failed on the CI.

@idulkin
Copy link

idulkin commented Nov 17, 2017

I'm encountering this issue as well. I believe it's related to test orchestrator. Because each test runs as its own instrumentation, Spoon is creating an xml report after each test, and overwriting the previous report for that device. So we only get the output of the last test to run on each device.

@jaredsburrows
Copy link
Contributor Author

@idulkin I do believe you are right, it seems to only save the "last" test because it keeps overriding the junit xml report, so there is only 1 test listed.

How can we force spoon to not run like this? Maybe using this new option, we can run all the tests together again? 53a63fe#diff-2a33694ea19ca0cbba8207fda7dcfbd6R73

@jaredsburrows
Copy link
Contributor Author

@idulkin Can you try using --single-instrumentation-call?

@idulkin
Copy link

idulkin commented Nov 17, 2017

@jaredsburrows I was just about to try that! I'm concerned about a single instrumentation losing Test Orchestrator's ability to isolate crashes, but let's see what happens.

@jaredsburrows
Copy link
Contributor Author

Yes, it seems to bring the junit reports back but the test are no longer isolated. This means that the CI cannot report back which tests failed unless you fail the build on the first failed test.

@idulkin
Copy link

idulkin commented Nov 18, 2017

I think the real problem isn't with Spoon, but with the XmlTestRunListener from ddmlib. When each instrumentation finishes, testRunEnded is called and a report is generated. It seems like we would need a completely different run listener to handle multiple instrumentations per test suite.

@edamyanov
Copy link
Contributor

edamyanov commented Feb 7, 2018

I think this PR 519 fixes this problem.

@tobi512
Copy link

tobi512 commented Feb 19, 2018

@jaredsburrows The fix of Emanuil looks good, would be great to have a quick merge here, since the broken reports currently block us a little bit...

@jaredsburrows
Copy link
Contributor Author

@tobi512 It needs to be merged here first. I am not an owner or collaborator of this repo.

@edenman
Copy link
Collaborator

edenman commented Mar 1, 2018

should be fixed on master now, sorry for the delay.

@edenman edenman closed this as completed Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants