Merge pull request #754 from squidowl/fix/infinite_scroll-default

Default Value for `infinite_scroll`
squidowl · Feb 5, 2025 · 97b41cc · 97b41cc
2 parents 011b136 + 821eca2
commit 97b41cc
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 # Unreleased
 
+Fixed:
+
+- [`infinite_scroll`](https://halloy.squidowl.org/configuration/buffer.html?highlight=infinite#infinite_scroll) was defaulting to `false`, contrary to its documented default value.  Now defaults to `true`.
+
 # 2025.1 (2025-02-02)
 
 Added:

diff --git a/data/src/config/buffer.rs b/data/src/config/buffer.rs
@@ -176,12 +176,20 @@ impl Default for InternalMessage {
     }
 }
 
-#[derive(Debug, Clone, Default, Deserialize)]
+#[derive(Debug, Clone, Deserialize)]
 pub struct ChatHistory {
-    #[serde(default)]
+    #[serde(default = "default_bool_true")]
     pub infinite_scroll: bool,
 }
 
+impl Default for ChatHistory {
+    fn default() -> Self {
+        Self {
+            infinite_scroll: true,
+        }
+    }
+}
+
 #[derive(Debug, Copy, Clone, Default, Deserialize)]
 #[serde(rename_all = "kebab-case")]
 pub enum UsernameFormat {