From d2453103ed450fa3bdfe83f8517ba7ac3141cfdf Mon Sep 17 00:00:00 2001 From: Andrew Baldwin Date: Tue, 4 Feb 2025 18:03:56 -0800 Subject: [PATCH 1/2] Change default value for `infinite_scroll` to true, to match the default given in the documentation. --- data/src/config/buffer.rs | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/data/src/config/buffer.rs b/data/src/config/buffer.rs index 20124770..7ea9f199 100644 --- a/data/src/config/buffer.rs +++ b/data/src/config/buffer.rs @@ -176,12 +176,20 @@ impl Default for InternalMessage { } } -#[derive(Debug, Clone, Default, Deserialize)] +#[derive(Debug, Clone, Deserialize)] pub struct ChatHistory { - #[serde(default)] + #[serde(default = "default_bool_true")] pub infinite_scroll: bool, } +impl Default for ChatHistory { + fn default() -> Self { + Self { + infinite_scroll: true, + } + } +} + #[derive(Debug, Copy, Clone, Default, Deserialize)] #[serde(rename_all = "kebab-case")] pub enum UsernameFormat { From 821eca2a7fd6fe139b93d18ca7ddb42f3eacc413 Mon Sep 17 00:00:00 2001 From: Andrew Baldwin Date: Wed, 5 Feb 2025 09:46:48 -0800 Subject: [PATCH 2/2] Note change to default value for `infintie_scroll` in changelog. --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 72a06904..9dfbe95c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,9 @@ # Unreleased +Fixed: + +- [`infinite_scroll`](https://halloy.squidowl.org/configuration/buffer.html?highlight=infinite#infinite_scroll) was defaulting to `false`, contrary to its documented default value. Now defaults to `true`. + # 2025.1 (2025-02-02) Added: