Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Description is used in task manager for Halloy on Windows #768

Closed
casperstorm opened this issue Feb 13, 2025 · 2 comments · Fixed by #772
Closed

Description is used in task manager for Halloy on Windows #768

casperstorm opened this issue Feb 13, 2025 · 2 comments · Fixed by #772

Comments

@casperstorm
Copy link
Member

Notice the title of the Halloy process in Task Manager on Windows:

Image

I believe it is caused by the windows_exe_info which is called here:

halloy/build.rs

Lines 4 to 5 in fbbde68

embed_resource::compile("assets/windows/halloy.rc", embed_resource::NONE);
windows_exe_info::versioninfo::link_cargo_env();

@KaiKorla - Something you could pick up if you have time?

@KaiKorla
Copy link
Contributor

I think we discussed this before (middle last year or so). We have two options:

Option 1:
Change the description field in the Cargo.toml to something shorter. AFAIK the best practices are: keep it short, clear & user-friendly. Maybe we could change the value to "Halloy IRC Client".

Option 2:
Rewrite the code windows_exe_info::versioninfo::link_cargo_env(); to set the file_description value of the file_info: vec![FileInfo. I dont know if this possible. If not, we have to overwrite/re-implement the windows_exe_info::versioninfo::link_cargo_env(); by ourself.

You choose! Then i would change it! :-)

regards
Kai

@casperstorm
Copy link
Member Author

I agree with this, @KaiKorla. Take a look at: #772.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants