From a3aaa7b1b02b18c586fe35a15a6fbafa3c92e4eb Mon Sep 17 00:00:00 2001 From: ravali-rimmalapudi <83863595+ravali-rimmalapudi@users.noreply.github.com> Date: Tue, 9 Nov 2021 11:50:23 +0530 Subject: [PATCH] fix: Added changes to fix the lcov issue (#170) * fix: Added the changes for lcov * Update package.json --- .github/workflows/cli-core-test.yml | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/.github/workflows/cli-core-test.yml b/.github/workflows/cli-core-test.yml index e683da42..2ddbfabe 100644 --- a/.github/workflows/cli-core-test.yml +++ b/.github/workflows/cli-core-test.yml @@ -14,6 +14,9 @@ jobs: steps: - name: Checkout cli core repo uses: actions/checkout@v2 + with: + # Disabling shallow clone is recommended for improving relevancy of reporting + fetch-depth: 0 - run: npm install - name: Use Node.js ${{ matrix.node-version }} uses: actions/setup-node@v2 @@ -22,21 +25,14 @@ jobs: cache: 'npm' - name: Run tests run: npm test - sonarcloud: - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - with: - # Disabling shallow clone is recommended for improving relevancy of reporting - fetch-depth: 0 - name: SonarCloud Scan uses: sonarsource/sonarcloud-github-action@master env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }} notify-complete-fail: - if: ${{ failure() || cancelled() }} - needs: [ test, sonarcloud ] + if: ${{ failure() && github.ref == 'refs/heads/main' && github.event_name != 'pull_request' }} + needs: [ test ] name: Notify Test Failed runs-on: ubuntu-latest steps: