Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update subprocess launching to be sane & secure #42

Open
PeterJCLaw opened this issue Jul 20, 2021 · 0 comments
Open

Update subprocess launching to be sane & secure #42

PeterJCLaw opened this issue Jul 20, 2021 · 0 comments

Comments

@PeterJCLaw
Copy link
Member

There's rather a lot of subprocess.Popen usage here, many of which use string formatting of one form or another to build the command they run. This may or not be insecure, we just don't know. Using the list based approach would be better.
Likely other utils in subprocess can also now simplify them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@PeterJCLaw