From 5c926727734639a823175aaa2a8cfdbf3590ab9f Mon Sep 17 00:00:00 2001
From: Dutta <ila.dutta@ssc-spc.gc.ca>
Date: Wed, 20 Nov 2024 10:15:17 -0500
Subject: [PATCH] update

---
 psmodules/Check-StorageAccountTLSversion.zip  | Bin 3560 -> 3517 bytes
 setup/modules.json                            |   4 ++--
 .../Audit/Check-StorageAccountTLSversion.psm1 |   6 ++----
 .../GR-ComplianceChecks-Msgs.psd1             |   2 ++
 .../fr-CA/GR-ComplianceChecks-Msgs.psd1       |   3 ++-
 5 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/psmodules/Check-StorageAccountTLSversion.zip b/psmodules/Check-StorageAccountTLSversion.zip
index cadb1b9903f8aaf3edf8b267847870f90242e9c7..f5c5f806d11505ea6bbbeb86bdf5629cfbf64ace 100644
GIT binary patch
delta 1718
zcmV;n21)to8@(H_2L=+XP;^;%n^Ka;1^@s78UO$z0F$i^C05N?TW{1j6n;nIKb%cR
zYDYAqg?(eU65ZK?Dz&9z3OpcGxrs9|Byq5vmI3<T_t<d~Cr+mAid}7x=)^ug*Y8}M
zq$(oCcmd0lMxVorlhrj9QZIaelavM~7r3|Ng%UhFBRL)2KSoZIn<spIu_?#*lkEl<
ze@&r^ioH`(#6)qiIhZL?(fP+Q5pQV8g}Pu9+AT9)#cw59({sTSmQe`@5d0SG1MI*#
zk&?zhBoL@ijIlW7ah0{lds1$gic%ywDzp`+Ri>B`*vi_0GkOCFC8`n>l8mhPA*KmI
zN>CgUl1Zvr)lBD)AJso*63s@P52J`ze}&S4L$zP*&Fk%i3reCC_GYrWl96Dg0S7DE
zFk3>44*jgC3J<^ONYk$h!j*III7Wfa`{Fq6&dmgsyb=+8C3sb8@4Ygd-nh$+-ul^r
z6V6LeDQ>J&Fp4%jU|mx;w4EV6DaMk%+_`JZh>JSKR=srydx~ll4_Gfeg1#V@e`r7V
zg)Npf?}Eaw^MPW60QI%eh7EXmmbDgkX?|AaRImtb9GqU9vV!GRev!#{wjzXrmKi}`
z2Y4QF9t6(PrCwMBFd?yHeq1CR#eFzmEh}8jZ5??rp{qfd10myQF#5W{^1bUmexx*m
z2L-FAPtQ|^pYK1PXqut#>-z*`LYki+U(L^39cOUs=A8SC)s80zUU2=x$Z_J;{%l1G
zish^rmGlE%a*-1in!5h@kvWqz?F(JPl8x?PNHs{*sZMs2x(F(NUGb0m<JKN|zr#Pj
zd+I;4W4YvcnK6Q(!hAAR_13VOAre;gPupQpTv#uFou8IG%kUN5C>Mu9kd3CC;&vni
z7Y}7sGuttfU9X19dPj+k+aYv^cbc8s|3f4Huue71t`f8HeM$vw6!|{8#DYf@g^+%M
zp!Rzl+*$|PG>-^>hNUOc@Xb)$#bF%p1uqFkC)N?5Uuje!JC#z{^)=dsi03)tHVm&#
z=EDYyH<VQ5OzH}U*eGIiniW!!EYq6v#H<{CYm2>v+~DhXTX|48)ha<wrH1Zvm|X@o
z{KjQCd)%OXn&vtDKh+(SR5N8vB?68JEy_(m2C(&R1)&{(11(y@rkr(!P0vM5&2j4w
zgiZDA>L`SE#&3sx2%F;9l|g{eDbBr0jXQps87n<uzm5#+3L<>MLp=afT^7FoTzCBo
z{+e{x02({+l4aNdG=e`<S^_V!4RB+TMC=g-DY>?&cE>HvYZpqv5y5I>tE20SWk!ic
z=fS{5!?J;YcwICEi}RWvqw+&AY%{?}SM7vhwxFA#@pHiy&@UCqv?;jpbn(n;l^6?Y
zJc!h&wqx3jjKM`c0YANb7Pv~GpJS%=eGZtw*qO`_0;CzxB~%i7RZl&WoMS3B_W-P>
zy?em02kGwb?BZTd>pM#ehXw17cxZN5_bgx%)jYv}s&bK%0xd;`T9j5;qro3A|A5x0
zX}|vfEc4+h&94x2_OC(l8CN<N4V)k}xb-v$-;oS87z}XZ-t+Yfv9tFyoZqc1j*>@s
z*=q4HkbL=b>_L!Csyp{YVwhf6s;rcW1GWQ}FobTMwBBHC4t2xyd!|w^u2a_gxp3^6
zfbcYb5bR$XcCg*GNE+k;b~>E6bb_?m&}K0j4A{(4wnot%yTLu#H^L^%fq!M*o-Pka
znSoCSsbd%wyl4;g?=L$3n*Vky(B&(t=eWk_;nCL;$AT6|BiBwJqZ%W(Fo*CH$4>&g
z`>?y+BhC<emrD@T-O(oy;6METZHbqMx<`0_p>B(D7glrVE?-Sw5NGGoTDtucLc=|x
zdMvGsDURhXVb?0nb1>2|Eyvm^&0`4bwT`Oo)DBg%)=@cKzNPBc9OSn{LPyuEdA+=?
z-k4k)AaOlU+BpVWCe32FBKqcpsiwEw>(BjWMW?9HYm(tusxM6SmEi~%Dx&2#B7f3<
zY}PLXzc`W?tCUw+Y$a3gdzUfCA#W91D=ZabU&mT_Ek*zoU;@BliOZ4pP_X6rgE~WC
z^$MDnFrxDvsy69rRHW7)F@$aSXJd|-o4KjP?_jk4g6IclVC1bg0=Me4SJe6{XI_Cv
zQ6;doz)h;Pu$t+*Us}bmQzUF%34<Iw_o`*ly<PI4aQz4F_X<*dBddGzSWR+t>@Zbx
zH&v<8xg#^KlLwtgyDhZJrntkwTb%f)=4z^4X9)fVlQ0ck4XjXfS$LaLlE(%B00EPl
M4M+wB4FCWD00BijW&i*H

delta 1758
zcmV<41|j*q8|WLb2L=(Q1$0?%+^VGV1^@to8UO$zlQ0b=SZy)QSzm9|I1qnF;ycWx
zE43?{)xo`SSBc(UL6zE4u>~Fws@%lc7?L<=J1q<JyWiMx5+_c!?Fmj7B-q&Fncw^$
zhomYZ#drbBlt!P!i<8wg6;dyJdy|v~CNuTk#ipeDup_H083|SzVO&5?3bLj-Efl;G
zyeh{|FL|K^&(26rN4Xy(j>*jvzBZ!A_LI>D7k>>w6%~7@q=<>)VskK4qN4MUV<O(r
zk_&agCeST2Ud3-En&4dUgk@C10R+DV`v5y|PNbwU5D5h86Jsn+d0b`f@t%|$rlJ%{
zjtZ^CX_YBv1h%qv;EditLW!ybg(M^EeTZp7kP;M!gk+LxRyEW4<45(6nMAb_^I;V6
zs((=0?FjqD-n`yUxS%9TVQ<#+HY?g7v4l3Z^s}NWJp8IXO}{7zSI)uX7zH}-i{rRE
zHxpFyN<`E|kG9?`!|9E?+~C&F4xDgaf=Y2?oq_?{@PKtc1Up4~Qj8{jxpP;S5fgR5
zR=srydq8y*4_Gfeg1#V@Xgl|XEtWO!f-%Cc^8v7dgZgN+Vgp{DX03)@kvOYzDp-U%
z4o)vlS;6uuzsTe}TTenk%Z#9{13ZtDAP5?N6?!p&)kK&RLdMQu@VbHJTi1PjPiY1Z
za#jyd&r*h;Z$F=CnxSv&`#5BppYLDI&s!a5aO>ur`;66&CkLK${lmy{;?@3aMGA`L
ztQeK_9bR&g6BU}e{`iqOlQhi_O~R6m?tVx$NYtr5c%N2vXS?bXob!xDo8!Os2YIlQ
zxd<44P4Tb$<JKN|zr#Pid+L8?$8yQ@GGhdT3iHWO)my`AhLNzUf7%X<;=+0X?DVzd
zS%$A@M!7f?f^0P96t^QGxOgb5n%Rz-3wt$G);mgU+zz2TywmL5{vR6ohjpr9c9oco
z?^7yh1LWK65(^$t6hitp1hw7c;MN+@rg=nv&@DZYhHr*w7l(1Y7rZ3somhK-exXr?
z>{Lo&*GIGq5zlb|jl=NTWIk-Lctc4=&ZMqz7#l@wPP0NPl4WLSP0Y&S*S6S8$W46x
zZYvK8ry3IERO--u4ztU^y5E=#XOA1yPt!by|0mp@$(ux)DV(Hr0=iujNoy)IiA*Jb
z3yu+OCK#s;LfgA{gmzT45v5=C91k^yu&IDuE!3k_Q>NUK1z}TgyV47xy%x0h0|=XX
z*;P(}(5dIW;*L9hWg4qiVZZbYOA#i;gu!|apt_QL`>EFZ3Fe!$-k@Laz)O~4579aB
znbHz?k!^q*1tmr=QIL{rn-^~AX<oa3PzsJYpf<L?x~5rXl<4?A7+7prcrfA@4Z-5P
z=Etb~5DXht@X>{xFw8f!Iy7c4xB~ijMKY}lZaiH)v#1iIA&m!)8$~;YZe)-y>KXd!
z<+H#Ag?5ga#`_$w1YmD7V+@dH#FtP>Oy(Xule%LNo0|mI<K9hT*v0hx;Oydmp1#uS
zM$m@Cf^|o{;C5K|G++{8o?u<NNJ)X3B10`o1J=>tkEnk@tJJjJzXLXk@Ra6P7<Beu
z6UAp->C`mg1fhvr4?*~jWQbre0*+hH#~0#k&_g)C8!Qf^M|fRp<6$8A^2g|dK{g3@
z?ukS<y{=SQDdPuhC@f(Zx^>cjdZW2H)Q#isnMyssPHFGw!m+0UhNlU^{<UKV8)h3x
zgFL`qi8Gr{kTx6IEJlU(r>T^!QFO;{aMSjcu*q`ZU%I!a%L7toVADbB7)Avz+C%*t
zkoLdkzg-J7`HJdEu(5e~^rghXqK%`Gi>n`_I!10`4&f(`9~E}@VRyTKMVvACE|XwT
zcSoN<fPe7sw<TUb>K@^_x-G_?Tg{=nY&CtwoSjRn>GqEh4flxZ!L~B0IGVeJU8^+D
z!AQrn9BZRAk0GqrI;yr)J5<eDN9A<+ma1EGBEKCHI=W`f>*a0r#^l-niR+2fjy2da
zX%@p3(RVLQHNE9tpzb$+NjgP^UXu(5TYcrKFC9m?P!TP^5&45gwSFP^#gV*NrM${w
zE17y<%#1n?c?)c<uvCnFUu(l_F%m!lCIB3kxEyH<1zV0ks51l>SJ1SC5zKc$ZPL|1
zq}CoWgsuB$V}_WUxv9i2Y5Knbuw3}g87O({O~fsn_L5s)2F)u}@F=PTwidWaH42MN
z*ZtB0!%mT~btO#XxR*5>-P<J(3fF&Ney<?ace=VKkJTgxV;563cT<%b%pI9Aojm9)
z+HIj$HpLwd-r~e(ITxumogw%KlLZZ34W<QjS#I2_r1Ay;0D+Tl4M+ws4FCWD09EWx
A5dZ)H

diff --git a/setup/modules.json b/setup/modules.json
index 9d40fb0b..36c6532e 100644
--- a/setup/modules.json
+++ b/setup/modules.json
@@ -462,14 +462,14 @@
       }
     ]
   },
-  {
+	{
     "ModuleName": "Check-StorageAccountTLSversion",
     "Control": "Guardrails7",
     "ModuleType": "Builtin",
     "Status": "Enabled",
     "Required": "True",
     "Profiles": [2, 3, 4, 5, 6],
-    "Script": "Verify-TLSForStorageAccount -ControlName $msgTable.CtrName7 -ItemName $msgTable.dataInTransit -MsgTable $msgTable  -ReportTime $ReportTime -CBSSubscriptionName $vars.cbssubscriptionName -itsgcode $vars.itsgcode -CloudUsageProfiles $cloudUsageProfilesString -ModuleProfiles $ModuleProfilesString",
+    "Script": "Verify-TLSForStorageAccount -ControlName $msgTable.CtrName7 -ItemName $msgTable.storageAccTLS12 -MsgTable $msgTable  -ReportTime $ReportTime -CBSSubscriptionName $vars.cbssubscriptionName -itsgcode $vars.itsgcode -CloudUsageProfiles $cloudUsageProfilesString -ModuleProfiles $ModuleProfilesString",
     "variables": [
       {
         "Name": "cbssubscriptionName",
diff --git a/src/GUARDRAIL 7 PROTECTION OF DATA-IN-TRANSIT/Audit/Check-StorageAccountTLSversion.psm1 b/src/GUARDRAIL 7 PROTECTION OF DATA-IN-TRANSIT/Audit/Check-StorageAccountTLSversion.psm1
index 663f56f5..7986068b 100644
--- a/src/GUARDRAIL 7 PROTECTION OF DATA-IN-TRANSIT/Audit/Check-StorageAccountTLSversion.psm1	
+++ b/src/GUARDRAIL 7 PROTECTION OF DATA-IN-TRANSIT/Audit/Check-StorageAccountTLSversion.psm1	
@@ -1,7 +1,6 @@
 function Check-TLSversion {
     param (
         [System.Object] $objList,
-        [string] $objType, #subscription or management Group
         [string] $ControlName,
         [string] $ItemName,
         [string] $LogType,
@@ -70,13 +69,12 @@ function Verify-TLSForStorageAccount {
         $Errorlist.Add("Failed to execute the 'Get-AzSubscription' command--verify your permissions and the installion of the Az.Resources module; returned error message: $_")
         throw "Error: Failed to execute the 'Get-AzSubscription' command--verify your permissions and the installion of the Az.Resources module; returned error message: $_"
     }
-    [string]$type = "subscription"
 
     if ($EnableMultiCloudProfiles) {   
-        $PSObjectList = Check-TLSversion -objList $objs -objType $type -itsgcode $itsgcode -ReportTime $ReportTime -ItemName $ItemName -LogType $LogType -msgTable $msgTable  -ControlName $ControlName -CloudUsageProfiles $CloudUsageProfiles -ModuleProfiles $ModuleProfiles -EnableMultiCloudProfiles
+        $PSObjectList = Check-TLSversion -objList $objs -itsgcode $itsgcode -ReportTime $ReportTime -ItemName $ItemName -LogType $LogType -msgTable $msgTable  -ControlName $ControlName -CloudUsageProfiles $CloudUsageProfiles -ModuleProfiles $ModuleProfiles -EnableMultiCloudProfiles
     }
     else {
-        $PSObjectList = Check-TLSversion -objList $objs -objType $type -itsgcode $itsgcode  -ReportTime $ReportTime -ItemName $ItemName -LogType $LogType -msgTable $msgTable -ControlName $ControlName
+        $PSObjectList = Check-TLSversion -objList $objs -itsgcode $itsgcode  -ReportTime $ReportTime -ItemName $ItemName -LogType $LogType -msgTable $msgTable -ControlName $ControlName
     }
 
     # Filter to keep only objects that have the 'subscriptionName' property
diff --git a/src/GuardRails-Localization/GR-ComplianceChecks-Msgs.psd1 b/src/GuardRails-Localization/GR-ComplianceChecks-Msgs.psd1
index 6fbc6e2f..d4987ba8 100644
--- a/src/GuardRails-Localization/GR-ComplianceChecks-Msgs.psd1
+++ b/src/GuardRails-Localization/GR-ComplianceChecks-Msgs.psd1
@@ -184,6 +184,8 @@ allCertificatesValid = All certificates are valid and from approved Certificate
 approvedCAFileFound = Approved Certificate Authority (CA) list file '{0}' found and processed
 approvedCAFileNotFound = Approved Certificate Authority (CA) file '{0}' not found in container '{1}' of storage account '{2}'. Unable to verify certificate authorities
 
+storageAccTLS12 = Storage Accounts TLS 1.2
+
 # GuardRail #8
 noNSG=No NSG is present.
 subnetCompliant = Subnet is compliant.
diff --git a/src/GuardRails-Localization/fr-CA/GR-ComplianceChecks-Msgs.psd1 b/src/GuardRails-Localization/fr-CA/GR-ComplianceChecks-Msgs.psd1
index 03c078e6..14f30216 100644
--- a/src/GuardRails-Localization/fr-CA/GR-ComplianceChecks-Msgs.psd1
+++ b/src/GuardRails-Localization/fr-CA/GR-ComplianceChecks-Msgs.psd1
@@ -111,7 +111,6 @@ nonCompliantC2= Configurez la politique d'accès conditionnel pour empêcher les
 nonCompliantC1C2 = Configurez les politiques d'accès conditionnel décrites dans les conseils de remédiation.
 compliantC1C2 = Les deux politiques d'accès conditionnel ont été configurées.
 
-
 # GuardRail #3
 noCompliantPoliciesfound=Aucune stratégie conforme n'a été trouvée. Les politiques doivent avoir un emplacement unique et cet emplacement doit être réservé au Canada.
 allPoliciesAreCompliant=Toutes les politiques sont conformes.
@@ -185,6 +184,8 @@ allCertificatesValid = Tous les certificats sont valides et provenant d'autorit
 approvedCAFileFound = Approved Certificate Authority (CA) file '{0}' not found in container '{1}' of storage account '{2}'. Unable to verify certificate authorities.
 approvedCAFileNotFound = Le fichier des Autorités de certification (AC) approuvées '{0}' n'a pas été trouvé dans le conteneur '{1}' du compte de stockage '{2}'. Incapable de vérifier les autorités de certification
 
+storageAccTLS12 = Storage Accounts TLS 1.2
+
 # GuardRail #8
 noNSG=Aucun NSG n'est présent.
 subnetCompliant = Le sous-réseau est conforme.