-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some fields are not specific to landsat and should be in separate extensions #2
Comments
PS: I feel the 2.0.0 release was a little fast, there was literaly no time for reviews. |
@m-mohr Agree we should use existing extensions as appropriate, just posted this with regard to Sentinel-2 data My thoughts on Landsat
|
Thanks, some comments below: scene_id: Records has the concept of externalIds, which could cater for this (as a STAC extension). So having a general concept for external IDs would be better than a proprietary field. collection_category: What does t1 and t2 mean? collection_number: Great, one proprietary field less. cloud_cover_land: WIll have a look at the EO issue... correction: So until it's standardized you can use product_generated: That sounds like an implementation issue shifted into the metadata? If the time is available in assets, you can query it in principle. |
I agree that this can and should be made better. The intention of this was to create a community spec matching the existing proprietary spec that's already in use by both Planetary Computer and Earth Search, with the addition of one field that I need to use for Earth Search work. We can always make these improvements and release as a v3.0.0 and as part of other to-be-created extensions. |
When discussion STAC extensions in the broader area of ARD recently (CEOS meeting, BiDS conference), it came up that some of the fields in this extension (and also the old extension) should not be in the landsam extension, but in other extension that are more generic.
For example, landsat:cloud_cover_land is a generic concept that is not specific to Landsat.
Similarly, product_generated seems to be covered by created on the asset level.
Similar questions could be raised for correction, path, row and other fields.
For each fields there should be a good reason, why the field is Landsat specific. Otherwise, it should be part of another extension.
We had the discussion that it would be appreciated if these fields could be generalized so that they can be reused and not end up also e.g. in a Sentinel extension. cc @philvarner
The text was updated successfully, but these errors were encountered: