Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query extension support does not allow Query extension JSON syntax #213

Closed
philvarner opened this issue Jun 2, 2022 · 2 comments
Closed
Assignees
Milestone

Comments

@philvarner
Copy link
Collaborator

The docs say The query filter will also accept complete JSON as per the specification., but it only accepts the simplified syntax that pystac-client made up (e.g., eo:cloud_cover<10). Not sure if we want to fix this or change the documentation.

@matthewhanson
Copy link
Member

This should be fixed to accept JSON, which I thought it was doing here:

If the query is not a list then it's a Dict (QueryLike type), which is then passed through as is.

@philvarner
Copy link
Collaborator Author

philvarner commented Jun 2, 2022

problem with that code is that the if is

if isinstance(value, list):

and it's a List[Dict[str,Any]] rather than a Dict[str,Any] because the arg has nargs="*",

@philvarner philvarner added this to the 0.4.0 milestone Jun 2, 2022
@philvarner philvarner self-assigned this Jun 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants