Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Landing Page not advertise conformance classes correctly #169

Closed
philvarner opened this issue Jul 2, 2021 · 7 comments · Fixed by #214
Closed

API Landing Page not advertise conformance classes correctly #169

philvarner opened this issue Jul 2, 2021 · 7 comments · Fixed by #214

Comments

@philvarner
Copy link
Collaborator

philvarner commented Jul 2, 2021

The landing page (root endpoint) does not have a conformsTo field, and the conformance classes in /conformance do not correspond to STAC API 1.0.0-beta.1 or 2. https://github.com/radiantearth/stac-api-spec/blob/master/overview.md#conformance-classes

This is an invalid STAC API as it works currently.

Planetary Computer does have a conformsTo field.

@philvarner philvarner changed the title pgstac does not advertise conformance classes correctly API Landing Page not advertise conformance classes correctly Jul 6, 2021
@moradology
Copy link
Collaborator

This should be addressed as a result of changes in #181 - the updated stac-pydantic Landing model includes conformance classes: https://github.com/stac-utils/stac-fastapi/pull/181/files#diff-fe72d159853c2c83c51a4c09af0905cbc8706b18f8fd42ca2491a8c02dc37c18R49

@philvarner
Copy link
Collaborator Author

I see that conformsTo exists now, but the classes are invalid.

"conformsTo": [
    "https://stacspec.org/STAC-api.html",
    "http://docs.opengeospatial.org/is/17-069r3/17-069r3.html#ats_geojson"
  ],

should be like:

"conformsTo": [
    "https://api.stacspec.org/v1.0.0-beta.2/core",
    "https://api.stacspec.org/v1.0.0-beta.2/ogcapi-features",
    "https://api.stacspec.org/v1.0.0-beta.2/item-search"
  ],

@moradology
Copy link
Collaborator

Makes sense. It seems like the analogous conformance classes aren't available at e.g. https://api.stacspec.org/v1.0.0/core - do you by chance know of their whereabouts? master should be past beta.2 now

@philvarner
Copy link
Collaborator Author

https://api.stacspec.org/v1.0.0-beta.2/core/

1.0.0-beta.2 is the current version of STAC API. 1.0.0-beta.3 will be released soon.

@moradology
Copy link
Collaborator

Yeah, looks like I confused beta with rc 🤦

@moradology
Copy link
Collaborator

@philvarner I believe things are now addressed in #214

@philvarner
Copy link
Collaborator Author

It looks right to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants