You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Initial, "blindly pull from upstream" update syncing with zlib v1.3.1 tracked here: #209
Good news: it builds, tests pass.
This was not as terrible as I initially expected but some sections will need a thorough review. Biggest issue is knowing if pulling a piece of code from upstream is patching an existing minizip code or it's replacing a modification/a fix made in quazip. There are quite a few small patches touching various issues that are exclusive to quazip so reviewing commit history is mandatory.
What are the actual modifications to minizip by quazip where we need to be careful when pulling?
const char* filename -> voidpf file API changes
some methods are extended with additional flags, UTF-8 handling
zip.c version_to_extract change
ZFAKECLOSE64, autoclose modifications
Notable changes from upstream pull:
removal of OF macro
lot's of comment typos
some type shuffling between int, long, uLong, type casts
TRYFREE -> free
code style used from upstream to minimize diff
defines NOUNCRYPT by default, left it commented in for reference
Sections in need of a careful review:
not using MAXU32 in unzip.c
usage of static in function definitions (C/C++ difference, implication?)
Pull in the latest minizip code
Observation: quite a few changes from the code that is currently in the repo.
Relavant issues:
#19
Slightly relavant:
#169
#107
The text was updated successfully, but these errors were encountered: