chore: ci (#317)

.eslintrc

@@ -1,3 +1,35 @@
 {
-  "extends": ["eslint-config-unjs"]
+  "extends": ["eslint-config-unjs"],
+  "rules": {
+    "unicorn/no-null": "off",
+    "require-await": "error",
+    "unicorn/filename-case": "off",
+    "unicorn/no-process-exit": "error",
+    "unicorn/prefer-ternary": "error",
+    "unicorn/prefer-top-level-await": "off",
+    "no-useless-constructor": "error",
+    "@typescript-eslint/no-unused-vars": [
+      "warn",
+      {
+        "argsIgnorePattern": "^_",
+        "varsIgnorePattern": "^_",
+      },
+    ],
+    "@typescript-eslint/no-namespace": "error",
+    "camelcase": "off",
+    "unicorn/prefer-code-point": "error",
+    "unicorn/prefer-string-slice": "off",
+    "unicorn/prefer-at": "off",
+    "unicorn/explicit-length-check": "off",
+    "unicorn/prefer-set-has": "off",
+    "no-empty": [
+      "error",
+      {
+        "allowEmptyCatch": true,
+      },
+    ],
+    "prefer-const": "error",
+    "unicorn/no-empty-file": "error",
+    "@typescript-eslint/no-non-null-assertion": "off",
+  },
 }

.github/workflows/lint-check.yml

@@ -0,0 +1,33 @@
+name: CI Linting
+
+on:
+  pull_request:
+
+jobs:
+  linting:
+    name: Run Linting
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - name: Enable Corepack
+        run: corepack enable
+
+      - name: Set up Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: 20
+          cache: pnpm
+
+      - name: Install dependencies
+        run: pnpm install
+
+      - name: Lint JavaScript
+        run: pnpm run lint:js
+
+      - name: Check formatting
+        run: pnpm run lint:format
+
+      - name: Type checking
+        run: pnpm run lint:types

e2e/publish.test.mts

@@ -1,7 +1,8 @@
-import { exec } from "child_process";
-import { platform } from "os";
-import wp from "wait-port";
+/* eslint-disable unicorn/no-process-exit */
+import { exec } from "node:child_process";
+import { platform } from "node:os";
 import assert from "node:assert";
+import wp from "wait-port";
 import ezSpawn from "@jsdevtools/ez-spawn";
 import pushWorkflowRunInProgressFixture from "./fixtures/workflow_run.in_progress.json" with { type: "json" };
 import prWorkflowRunRequestedFixture from "./fixtures/pr.workflow_run.requested.json" with { type: "json" };
@@ -246,8 +247,8 @@ async function killPort() {
         killSignal: "SIGINT",
       });
     }
-  } catch (e) {
-    console.error(e);
+  } catch (error) {
+    console.error(error);
     c.abort();
     process.exit(1);
   } finally {

package.json

@@ -13,6 +13,7 @@
     "lint": "pnpm run \"/lint:.*/\"",
     "lint:js": "eslint --cache .",
     "lint:format": "prettier --check --cache .",
+    "lint:fix": "prettier --write --cache .",
     "lint:types": "pnpm -r --parallel run typecheck",
     "release": "tsx script/release.ts",
     "test": "tsx e2e/publish.test.mts",

packages/backend/objects.ts

@@ -1,10 +1,5 @@
-import { DurableObjectState } from "@cloudflare/workers-types";
-import type { Env } from "nitro-cloudflare-dev";
-
 export class Workflows {
-  constructor(state: DurableObjectState, env: Env) {}
-
-  async fetch(request: Request) {
+  fetch() {
     return new Response("Hello World");
   }
 }

packages/backend/script/ci.ts

@@ -1,9 +1,11 @@
-import fs from "fs/promises";
+import fs from "node:fs/promises";
 if (process.env.CI) {
-  const content = Object.entries(process.env)
-    .filter(([k]) => k.startsWith("NITRO"))
-    .map(([k, v]) => `${k}="${v}"`)
-    .concat(["NITRO_TEST=true", "GITHUB_TOKEN=" + process.env.GITHUB_TOKEN!])
-    .join("\n");
+  const content = [
+    ...Object.entries(process.env)
+      .filter(([k]) => k.startsWith("NITRO"))
+      .map(([k, v]) => `${k}="${v}"`),
+    "NITRO_TEST=true",
+    "GITHUB_TOKEN=" + process.env.GITHUB_TOKEN!,
+  ].join("\n");
   await fs.writeFile(".dev.vars", content);
 }

packages/backend/script/octokit.ts

@@ -1,5 +1,5 @@
-import esbuild from "esbuild";
 import { fileURLToPath } from "node:url";
+import esbuild from "esbuild";
 import { polyfillNode } from "esbuild-plugin-polyfill-node";
 
 await esbuild.build({

packages/backend/script/update-webhook-url.ts

@@ -26,7 +26,7 @@ const octokit = new Octokit({
   auth: jwtToken,
 });
 
-let {
+const {
   data: { url },
 } = await octokit.request("GET /app/hook/config");
 

packages/backend/server/middleware/cors.ts

@@ -1,5 +1,5 @@
 export default defineEventHandler((event) => {
   if (handleCors(event, {})) {
-    return;
+    console.log("CORS was successfully handled");
   }
 });

packages/backend/server/octokit.ts

@@ -27,6 +27,12 @@ import { createAppAuth } from "@octokit/auth-app";
 import { OAuthApp } from "@octokit/oauth-app";
 import { Webhooks, type EmitterWebhookEvent } from "@octokit/webhooks";
 
+import type { Octokit } from "@octokit/core";
+import { createUnauthenticatedAuth } from "@octokit/auth-unauthenticated";
+
+// https://github.com/octokit/app.js/blob/main/src/types.ts
+import type { Endpoints } from "@octokit/types";
+
 type Constructor<T> = new (...args: any[]) => T;
 
 type OctokitType<TOptions extends Options> =
@@ -64,6 +70,7 @@ export class App<TOptions extends Options = Options> {
     clientType: "github-app";
     Octokit: OctokitClassType<TOptions>;
   }>;
+
   log: {
     debug: (message: string, additionalInfo?: object) => void;
     info: (message: string, additionalInfo?: object) => void;
@@ -136,9 +143,6 @@ export class App<TOptions extends Options = Options> {
   }
 }
 
-import type { Octokit } from "@octokit/core";
-import { createUnauthenticatedAuth } from "@octokit/auth-unauthenticated";
-
 export function webhooks(
   appOctokit: Octokit,
   options: Required<Options>["webhooks"],
@@ -173,11 +177,10 @@ export function webhooks(
           return new auth.octokit.constructor({
             ...auth.octokitOptions,
             authStrategy: createAppAuth,
-            ...{
-              auth: {
-                ...auth,
-                installationId,
-              },
+
+            auth: {
+              ...auth,
+              installationId,
             },
           });
         },
@@ -201,9 +204,6 @@ export function webhooks(
   });
 }
 
-// https://github.com/octokit/app.js/blob/main/src/types.ts
-import type { Endpoints } from "@octokit/types";
-
 export type Options = {
   appId?: number | string;
   privateKey?: string;

packages/backend/server/plugins/error.ts

@@ -1,5 +1,5 @@
 export default defineNitroPlugin((nitro) => {
-  nitro.hooks.hook("error", async (error, { event }) => {
+  nitro.hooks.hook("error", (error, { event }) => {
     console.error(`${event?.path} Application error:`, error);
   });
 });

packages/backend/server/routes/[owner]/[repo]/[npmOrg]/[packageAndRefOrSha].get.ts

@@ -5,7 +5,7 @@ type Params = Omit<WorkflowData, "sha" | "isPullRequest" | "ref"> & {
   packageAndRefOrSha: string;
 };
 
-export default eventHandler(async (event) => {
+export default eventHandler((event) => {
   const params = getRouterParams(event) as Params;
   const [noScopePackageName, refOrSha] = params.packageAndRefOrSha.split("@");
   const packageName = params.npmOrg + "/" + noScopePackageName;

packages/backend/server/routes/[owner]/[repo]/[packageAndRefOrSha].get.ts

@@ -1,13 +1,14 @@
-import { WorkflowData } from "../../../types";
 import { abbreviateCommitHash } from "@pkg-pr-new/utils";
 import { normalizeKey } from "unstorage";
+import { WorkflowData } from "../../../types";
 
 type Params = Omit<WorkflowData, "sha" | "ref"> & {
   packageAndRefOrSha: string;
 };
 
 export default eventHandler(async (event) => {
   const params = getRouterParams(event) as Params;
+  // eslint-disable-next-line prefer-const
   let [encodedPackageName, longerRefOrSha] =
     params.packageAndRefOrSha.split("@");
   const packageName = decodeURIComponent(encodedPackageName);
@@ -17,7 +18,7 @@ export default eventHandler(async (event) => {
     ? abbreviateCommitHash(longerRefOrSha)
     : longerRefOrSha;
 
-  let base = `${params.owner}:${params.repo}:${refOrSha}`;
+  const base = `${params.owner}:${params.repo}:${refOrSha}`;
   let packageKey = `${base}:${packageName}`;
 
   const cursorKey = base;
@@ -48,7 +49,9 @@ export default eventHandler(async (event) => {
     // https://github.com/unjs/unstorage/blob/e42c01d0c22092f394f57e3ec114371fc8dcf6dd/src/drivers/utils/index.ts#L14-L19
     const [keySha, ...keyPackageNameParts] = trimmedKey.split(":").slice(2);
     const keyPackageName = keyPackageNameParts.join(":");
-    if (keyPackageName !== normalizeKey(packageName)) continue;
+    if (keyPackageName !== normalizeKey(packageName)) {
+      continue;
+    }
 
     if (keySha.startsWith(longerRefOrSha)) {
       packageKey = trimmedKey;
@@ -81,8 +84,8 @@ export default eventHandler(async (event) => {
   });
 });
 
-const sha1Regex = /^[a-f0-9]{40}$/i;
-const sha256Regex = /^[a-f0-9]{64}$/i;
+const sha1Regex = /^[\da-f]{40}$/i;
+const sha256Regex = /^[\da-f]{64}$/i;
 
 function isValidGitHash(hash: string): boolean {
   return sha1Regex.test(hash) || sha256Regex.test(hash);

packages/backend/server/routes/[owner]/[repo]/index.get.ts

@@ -1,6 +1,6 @@
 import { getPackageManifest } from "query-registry";
-import { WorkflowData } from "../../../types";
 import { extractOwnerAndRepo, extractRepository } from "@pkg-pr-new/utils";
+import { WorkflowData } from "../../../types";
 
 type Params = Omit<WorkflowData, "sha" | "ref">;
 

packages/backend/server/routes/[packageAndRefOrSha].get.ts

@@ -1,6 +1,6 @@
-import { WorkflowData } from "../types";
 import { getPackageManifest } from "query-registry";
 import { extractOwnerAndRepo, extractRepository } from "@pkg-pr-new/utils";
+import { WorkflowData } from "../types";
 
 type Params = Omit<WorkflowData, "sha" | "ref"> & {
   packageAndRefOrSha: string;

packages/backend/server/routes/multipart/complete.post.ts

@@ -1,11 +1,7 @@
 import type { R2UploadedPart } from "@cloudflare/workers-types";
 
 export default eventHandler(async (event) => {
-  const {
-    key: key,
-    id: id,
-    "uploaded-parts": uploadedPartsHeader,
-  } = getHeaders(event);
+  const { key, id, "uploaded-parts": uploadedPartsHeader } = getHeaders(event);
 
   const binding = useBinding(event);
 

packages/backend/server/routes/multipart/upload.put.ts

@@ -1,9 +1,5 @@
 export default eventHandler(async (event) => {
-  const {
-    key: key,
-    id: id,
-    "part-number": partNumberHeader,
-  } = getHeaders(event);
+  const { key, id, "part-number": partNumberHeader } = getHeaders(event);
 
   const partNumber = Number(partNumberHeader);
   const binding = useBinding(event);