Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add target DKG rounds configuration parameter #1207

Closed
1 task
cylewitruk opened this issue Jan 13, 2025 · 0 comments · Fixed by #1204
Closed
1 task

[Feature]: Add target DKG rounds configuration parameter #1207

cylewitruk opened this issue Jan 13, 2025 · 0 comments · Fixed by #1204
Assignees
Labels
sbtc signer binary The sBTC Bootstrap Signer.

Comments

@cylewitruk
Copy link
Member

cylewitruk commented Jan 13, 2025

Feature - Add target DKG rounds configuration parameter

1. Description

Add a new configuration parameter for specifying the target (i.e. max) number of DKG rounds that can be performed (#1199) or accepted (#1200) by the sBTC signer.

1.1 Context & Purpose

We want to support full DKG. But that is difficult so we are tackling it in phases. Phase 0 was running DKG once. Phase 1 was supporting DKG a second time, and this ticket is part of phase 1.

2. Technical Details:

Add a new optional signer config variable for the second DKG run. For the example production configs, set the target to 2. The default for this parameter should be 1 to prevent an accidental mis-configuration (or lack of setting this value) by signer partners from accidentally allowing unbounded DKG runs.

2.1 Acceptance Criteria:

  • We have a required configuration variable for the second DKG run.

3. Related Issues and Pull Requests (optional):

This relates to #1200, #1199 and #1152, which together add support for the second DKG run.

@cylewitruk cylewitruk added the sbtc signer binary The sBTC Bootstrap Signer. label Jan 13, 2025
@cylewitruk cylewitruk added this to the sBTC: Key rotation milestone Jan 13, 2025
@cylewitruk cylewitruk self-assigned this Jan 13, 2025
@cylewitruk cylewitruk added this to sBTC Jan 13, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Jan 13, 2025
@cylewitruk cylewitruk moved this from Needs Triage to In Progress in sBTC Jan 13, 2025
@cylewitruk cylewitruk moved this from In Progress to In Review in sBTC Jan 13, 2025
@github-project-automation github-project-automation bot moved this from In Review to Done in sBTC Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc signer binary The sBTC Bootstrap Signer.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant