Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tech Debt]: Add a test for exiting early during pre-sign request creation #1217

Closed
djordon opened this issue Jan 14, 2025 · 1 comment
Closed

[Tech Debt]: Add a test for exiting early during pre-sign request creation #1217

djordon opened this issue Jan 14, 2025 · 1 comment
Labels
tech debt
Milestone
sBTC: Withdrawal ...

Comments

@djordon
Copy link
Collaborator

djordon commented Jan 14, 2025

Description

PR that introduced tech-debt: #1215

The above PR adds functionality without a test. It's simple functionality that is difficult to test, so the author decided to push it off until later.
@djordon djordon added this to sBTC Jan 14, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Jan 14, 2025
@djordon djordon mentioned this issue Jan 14, 2025
Merged
1 task
@djordon
Copy link
Collaborator Author

djordon commented Jan 24, 2025

This was completed in #1190

@djordon djordon closed this as completed Jan 24, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Done in sBTC Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt
Projects
sBTC
Status: Done
Milestone
sBTC: Withdrawal Minimum Working Flow
Development

No branches or pull requests
1 participant
@djordon