Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Ensure recipient Stacks addresses matches the network #1228

Open
1 task
djordon opened this issue Jan 16, 2025 · 0 comments · May be fixed by #1229
Open
1 task

[Bug]: Ensure recipient Stacks addresses matches the network #1228

djordon opened this issue Jan 16, 2025 · 0 comments · May be fixed by #1229
Assignees
Labels
bug Something isn't working

Comments

@djordon
Copy link
Collaborator

djordon commented Jan 16, 2025

Bug - Ensure recipient Stacks addresses matches the network

1. Description

We should include a check for the recipient network as part of deposit script validation. This will ensure that a user cannot lose their funds if they make a mistake with the network of the Stacks recipient.

1.1 Context & Purpose

Depositors embed the recipient in the deposit request, and the signers are supposed to mint to this recipient after the deposited funds have been swept. But we do not check that the recipient matches the network that the signers are operating in. This leads to the depositor losing their funds. Better to check for this upfront and allow the depositor to reclaim their funds if this kind of mistake is made.

2. Technical Details:

Add a check for the network during the validation of deposit scripts.

2.1 Acceptance Criteria:

  • We reject deposits where the recipient in the deposit script doesn't match the network that signers are operating under.

3. Related Issues and Pull Requests (optional):

@djordon djordon added the bug Something isn't working label Jan 16, 2025
@djordon djordon added this to the sBTC: Key rotation milestone Jan 16, 2025
@djordon djordon added this to sBTC Jan 16, 2025
@djordon djordon moved this to Todo in sBTC Jan 16, 2025
@djordon djordon self-assigned this Jan 16, 2025
@djordon djordon moved this from Todo to In Progress in sBTC Jan 16, 2025
@djordon djordon moved this from In Progress to In Review in sBTC Jan 16, 2025
@djordon djordon linked a pull request Jan 16, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

1 participant