Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Make sure signers go through the validation code path #696

Closed
1 task done
djordon opened this issue Oct 23, 2024 · 0 comments · Fixed by #930
Closed
1 task done

[Feature]: Make sure signers go through the validation code path #696

djordon opened this issue Oct 23, 2024 · 0 comments · Fixed by #930
Assignees
Labels
sbtc signer binary The sBTC Bootstrap Signer.

Comments

@djordon
Copy link
Collaborator

djordon commented Oct 23, 2024

Feature - Make sure signers go through the validation code path

1. Description

The code that signs bitcoin transactions does not go through the bitcoin validation code path. It needs to.

1.1 Context & Purpose

A signer needs to validate a bitcoin sign requests before it provides a signature. Right now the signers always sign the request partly because they don't try to validate it.

2. Technical Details:

2.1 Acceptance Criteria:

  • We call the function that is supposed to do validation of the bitcoin transaction before providing signature shares.

3. Related Issues and Pull Requests (optional):

This is the last part of #286.

@djordon djordon added the sbtc signer binary The sBTC Bootstrap Signer. label Oct 23, 2024
@djordon djordon added this to the sBTC: Deposit ready milestone Oct 23, 2024
@djordon djordon added this to sBTC Oct 23, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage in sBTC Oct 23, 2024
@djordon djordon moved this from Needs Triage to Todo in sBTC Oct 23, 2024
@djordon djordon assigned djordon and unassigned djordon Nov 14, 2024
@djordon djordon self-assigned this Nov 23, 2024
@djordon djordon moved this from Todo to In Progress in sBTC Nov 23, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in sBTC Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sbtc signer binary The sBTC Bootstrap Signer.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant