Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a reference implementation using Fit SDK library for validation #21

Open
stadelmanma opened this issue Dec 8, 2022 · 1 comment
Labels
enhancement New feature or request

Comments

@stadelmanma
Copy link
Owner

Having a very basic reference implementation that I can compare my library’s output against would make fuzzing out bugs and corner cases much easier. It probably makes sense to output data in something easy to work with on the CLI, maybe a tab-delimited file similar to the FitToCSV tool output.

@stadelmanma stadelmanma added the enhancement New feature or request label Dec 8, 2022
@stadelmanma stadelmanma changed the title Create a reference implantation using Fit SDK java library for testing Create a reference implementation using Fit SDK java library for testing Dec 8, 2022
@stadelmanma stadelmanma changed the title Create a reference implementation using Fit SDK java library for testing Create a reference implementation using Fit SDK library for validation Feb 7, 2023
@stadelmanma
Copy link
Owner Author

The CPP code looks like a good start for this. Yeah We’ll want to track the message name & number, and then inside that the field name, number, value and type.

Whatever format the implementation creates we’ll need it to be:

  • easy to read
  • easy to view a diff of (e.g. using git diff)
  • simple to generate (no extra libs needed)
  • easy to parse

The first two reqs mean we will want to keep line lengths reasonable which excludes JSON lines. True JSON is also not exceptionally easy to parse or generate without pulling in extra libraries anyways. For parsing ease we want to avoid multiple spaces as a delimiter; single tabs and and new lines are fine.

A basic indented structure comes to mind:

HEADER
:TAB:header field
…

MesgNum,Message Name
:TAB:FieldNum,FieldName,FieldType,Value
…

…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant